feat: integrate update_property non implemented functions on main db - #170
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 96.15% 95.76% -0.40%
==========================================
Files 20 20
Lines 3097 3235 +138
==========================================
+ Hits 2978 3098 +120
- Misses 119 137 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pesap
left a comment
There was a problem hiding this comment.
Please address the inline findings before merging. The update implementation should reuse the existing property validation and membership-resolution paths, and follow the established bulk insertion pattern for batch execution. Keep update_property() as a thin public wrapper; removing the shared helper is not required if it cleanly centralizes the selector logic. Please also add coverage for rollback after domain-validation failures, scenario-scoped updates, explicit parent membership selection, and reusing the connection after a failed batch.
|
@pesap you can check it out again. |
This PR addresses Issue #179 implementing:
update_property()with corresponding additional configuration params.executemany().