Skip to content

feat: integrate update_property non implemented functions on main db - #170

Merged
mcllerena merged 20 commits into
mainfrom
ml/functions
Aug 31, 2026
Merged

feat: integrate update_property non implemented functions on main db#170
mcllerena merged 20 commits into
mainfrom
ml/functions

Conversation

@mcllerena

@mcllerena mcllerena commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This PR addresses Issue #179 implementing:

  • A property update support for both single-record and bulk workflows.
  • Adds update_property() with corresponding additional configuration params.
  • Scalability processing through batching and executemany().
  • Reusable code across CRUD operations.
  • Update documentation for operation examples.

@codecov-commenter

codecov-commenter commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.76%. Comparing base (6caf473) to head (73afe89).

Files with missing lines Patch % Lines
src/plexosdb/db.py 86.92% 20 Missing ⚠️
src/plexosdb/utils.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   96.15%   95.76%   -0.40%     
==========================================
  Files          20       20              
  Lines        3097     3235     +138     
==========================================
+ Hits         2978     3098     +120     
- Misses        119      137      +18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pesap pesap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the inline findings before merging. The update implementation should reuse the existing property validation and membership-resolution paths, and follow the established bulk insertion pattern for batch execution. Keep update_property() as a thin public wrapper; removing the shared helper is not required if it cleanly centralizes the selector logic. Please also add coverage for rollback after domain-validation failures, scenario-scoped updates, explicit parent membership selection, and reusing the connection after a failed batch.

Comment thread src/plexosdb/db.py
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread tests/test_plexosdb_update_property.py
@mcllerena
mcllerena requested a review from pesap August 13, 2026 19:20
@mcllerena mcllerena linked an issue Aug 31, 2026 that may be closed by this pull request
@mcllerena mcllerena changed the title feat: implement initial missing functions on main db feat: integrate update_property non implemented functions on main db Aug 31, 2026
@mcllerena
mcllerena requested a review from akrivi August 31, 2026 17:24
@mcllerena

Copy link
Copy Markdown
Contributor Author

@pesap you can check it out again.

Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread docs/source/howtos/bulk_operations.md Outdated
Comment thread src/plexosdb/db.py Outdated
@pesap
pesap self-requested a review August 31, 2026 21:12
@mcllerena
mcllerena requested a review from pesap August 31, 2026 23:23
@mcllerena
mcllerena merged commit 96c0334 into main Aug 31, 2026
28 checks passed
@mcllerena
mcllerena deleted the ml/functions branch August 31, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement PlexosDB.update_property

3 participants