Skip to content

Fix issue #190: Check Python version and locale encoding at startup #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronchantrill merged 3 commits into from
Aug 31, 2026
Merged

Fix issue #190: Check Python version and locale encoding at startup #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7b6d36
Fix issue #190: check Python version and locale encoding at startup b…
Sekhar03 Aug 13, 2026
670c0d8
Address CodeQL empty except warning
Sekhar03 Aug 21, 2026
5e8c4b6
Restore shebang and coding comment headers
Sekhar03 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions Naomi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
#!/usr/bin/env python3
# -*- coding: utf-8 -*-
import naomi
import sys

if(sys.version_info.major < 3):
raise SystemError("This version of Naomi requires Python 3.5 or greater")
if (sys.version_info.major < 3):
sys.stderr.write("Error: This version of Naomi requires Python 3.5 or greater\n")
sys.exit(1)

import locale
try:
encoding = locale.getpreferredencoding()
if encoding and encoding.lower() not in ('utf-8', 'utf8'):
sys.stderr.write("WARNING: Your system locale is configured to use a non-UTF-8 character encoding ({}).\n".format(encoding))
sys.stderr.write("This may cause Naomi to crash when reading files or configuration containing international characters.\n")
sys.stderr.write("Please consider setting your system locale to UTF-8 (e.g. by setting LC_ALL=en_US.UTF-8 in Linux).\n")
except Exception:
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
# Ignore any errors during encoding check so startup doesn't fail
pass

import naomi

naomi.main()

20 changes: 17 additions & 3 deletions Populate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
#!/usr/bin/env python3
# -*- coding: utf-8 -*-
import naomi
import sys

if(sys.version_info.major < 3):
raise SystemError("This version of Naomi requires Python 3.5 or greater")
if (sys.version_info.major < 3):
sys.stderr.write("Error: This version of Naomi requires Python 3.5 or greater\n")
sys.exit(1)

import locale
try:
encoding = locale.getpreferredencoding()
if encoding and encoding.lower() not in ('utf-8', 'utf8'):
sys.stderr.write("WARNING: Your system locale is configured to use a non-UTF-8 character encoding ({}).\n".format(encoding))
sys.stderr.write("This may cause Naomi to crash when reading files or configuration containing international characters.\n")
sys.stderr.write("Please consider setting your system locale to UTF-8 (e.g. by setting LC_ALL=en_US.UTF-8 in Linux).\n")
except Exception:
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
# Ignore any errors during encoding check so startup doesn't fail
pass

import naomi

naomi.main(args=["--repopulate"])

Loading