Skip to content

Rename URM helpers and credentials to Artifactory naming in CI and build config [databricks]#14678

Open
NvTimLiu wants to merge 2 commits intoNVIDIA:mainfrom
NvTimLiu:urm-to-art
Open

Rename URM helpers and credentials to Artifactory naming in CI and build config [databricks]#14678
NvTimLiu wants to merge 2 commits intoNVIDIA:mainfrom
NvTimLiu:urm-to-art

Conversation

@NvTimLiu
Copy link
Copy Markdown
Collaborator

@NvTimLiu NvTimLiu commented Apr 24, 2026

To fix: #14677

Documentation

  • Updated for new or modified user-facing features or behaviors
  • No user-facing change

Testing

  • Added or modified tests to cover new code paths
  • Covered by existing tests
    (Please provide the names of the existing tests in the PR description.)
  • Not required

Performance

  • Tests ran and results are added in the PR description
  • Issue filed with a link in the PR description
  • Not required

@NvTimLiu NvTimLiu self-assigned this Apr 24, 2026
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Apr 24, 2026
@NvTimLiu NvTimLiu requested a review from a team as a code owner April 24, 2026 05:40
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 24, 2026

Greptile Summary

This PR renames all URM_URLART_URL and URM_CREDSART_CREDS environment variable references across CI scripts, Maven/Ivy settings files, and the Dockerfile to align with Artifactory naming conventions. The rename is consistent and complete across all 11 changed files, with Maven profile IDs (mirror-apache-to-urm, deploy-to-urm) and the MVN_URM_MIRROR Jenkinsfile variable intentionally preserved since they are referenced by name in other tooling.

Confidence Score: 5/5

Safe to merge — purely a variable/env rename with no logic changes; all occurrences updated consistently.

All changed files are CI/build scripts with no Scala/Java/Python logic changes. The rename from URM_* to ART_* is applied uniformly across all 11 files. The only previously-noted concern (Jenkins credential store ID urm_creds not being renamed) was already flagged in a prior review thread. All remaining findings are P2 or lower.

jenkins/Jenkinsfile-blossom.premerge — confirm the Jenkins credential store ID matches the expected name after migration.

Important Files Changed

Filename Overview
jenkins/Jenkinsfile-blossom.premerge Renames URM_CREDS → ART_CREDS and URM_URL → ART_URL; credential store ID "urm_creds" is unchanged (previously flagged); MVN_URM_MIRROR variable name not updated
jenkins/settings.xml All URM_CREDS_USR/PSW and URM_URL env var references renamed to ART_* equivalents; Maven profile IDs mirror-apache-to-urm and deploy-to-urm intentionally preserved
jenkins/ivysettings.xml URM_CREDS and URM_URL env var references updated to ART_CREDS and ART_URL consistently
jenkins/hybrid_execution.sh URM_URL → ART_URL substituted in all wget and default-value assignments; copyright year updated to 2025-2026
dist/build/package-parallel-worlds.py Python local variable urm_url → art_url and guarding conditional updated accordingly
jenkins/Dockerfile-blossom.integration.rocky ARG and comment renamed from URM_URL to ART_URL; wget command updated consistently
jenkins/version-def.sh Three PROJECT_REPO / PROJECT_TEST_REPO / SPARK_REPO default assignments switched from URM_URL to ART_URL
jenkins/databricks/deploy.sh SERVER_URL default assignment updated from URM_URL to ART_URL; no other logic changes
jenkins/spark-nightly-build.sh SERVER_URL default in deploy invocation updated from URM_URL to ART_URL
dist/maven-antrun/build-parallel-worlds.xml Echo property key renamed from URM_URL to ART_URL in Ant build script
scripts/prioritize-commits.sh -DrepoUrl argument updated from URM_URL to ART_URL in maven-dependency-plugin invocation

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Jenkins Pipeline\nJenkinsfile-blossom.premerge] -->|ART_URL\nART_CREDS| B[Maven Settings\nsettings.xml]
    A -->|ART_URL\nART_CREDS| C[Ivy Settings\nivysettings.xml]
    A -->|ART_URL| D[Dockerfile\nDockerfile-blossom.integration.rocky]
    A -->|ART_URL| E[hybrid_execution.sh]
    A -->|ART_URL| F[version-def.sh]
    A -->|ART_URL| G[spark-nightly-build.sh]
    A -->|ART_URL| H[databricks/deploy.sh]
    A -->|ART_URL| I[scripts/prioritize-commits.sh]
    B -->|ART_URL| J[dist/build/\npackage-parallel-worlds.py]
    B -->|ART_URL| K[dist/maven-antrun/\nbuild-parallel-worlds.xml]
Loading

Reviews (2): Last reviewed commit: "Update license header" | Re-trigger Greptile

Comment thread jenkins/Jenkinsfile-blossom.premerge
@NvTimLiu NvTimLiu changed the title Rename URM helpers and credentials to Artifactory naming in CI and bu… Rename URM helpers and credentials to Artifactory naming in CI and build config [databricks] Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to CI / CD or cleanly building

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants