fix(self-managed): support disabled profile rendering

[sbaum1994]

Why

Validate #509's disabled profile while restoring plain make and OUTPUT_DIR-aware compute renders.

What changed

• Add the self-managed Makefile wrapper.
• Add render-only BDD coverage and table assertions.
• Read compute registration values from OUTPUT_DIR.

Customer Release Notes

Source installs support plain make and custom output directories.

Plan Summary

No resource changes.

Usage

make -C deploy/stacks/self-managed template HELMFILE_ENV=<environment>

Testing

Profile, golden, short, lint, and live render tests passed (17/17 steps).

Notes

Render-only PR1 for #522.

Issues

Relates to #522

References

#509

Related Pull Requests

#509

Dependencies

None; no license or NOTICE changes.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds render-only BDD coverage for self-managed and compute-plane Helmfile stacks with observability disabled. The changes add stable registration fixtures, a public Makefile entry point, manifest exclusion assertions, command wiring, and a live test entry point.

Changes

Observability-disabled BDD coverage

Layer / File(s)	Summary
Render scenario and stack entry point tests/bdd/features/observability-disabled.feature, tests/bdd/fixtures/ncp-local-register-values.yaml, deploy/stacks/self-managed/Makefile	Renders both Helmfile stacks with observability disabled, checks for absent observability resources, supplies static registration values, and adds the self-managed Makefile entry point.
Manifest exclusion assertion tests/bdd/dsl/*, tests/bdd/steps/assertion_steps.go, tests/bdd/steps/steps_test.go, tests/bdd/PLAN.md	Adds and documents FilesDoNotContain, validates its BDD table input, and tests matching-content and empty-directory errors.
BDD execution wiring and live entry point tests/bdd/godog_test.go	Verifies template command environments, copies registration values and placeholder outputs, and adds the live TestObservabilityDisabled entry point.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Godog
  participant Make
  participant Helmfile
  participant RenderedOutput
  Godog->>Make: Run template for both stacks
  Make->>Helmfile: Invoke template with disabled-observability environment
  Helmfile->>RenderedOutput: Write rendered manifests
  Godog->>RenderedOutput: Scan for forbidden observability resources

Loading

Suggested reviewers: famousdirector

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits and accurately describes support for rendering with the disabled observability profile.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/bdd-observability-disabled

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (2)

tests/bdd/godog_test.go (2)

645-645: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use the wiring suite’s actual repository root.

The feature expands ${REPO_ROOT} for output paths, but fixtures are seeded under suite.Config.RepoRoot. The fake runner currently hides this mismatch because it does not execute the render commands. Set REPO_ROOT to suite.Config.RepoRoot so the wiring test exercises a coherent path contract.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/bdd/godog_test.go` at line 645, Update the environment setup in the
wiring test to set REPO_ROOT from suite.Config.RepoRoot instead of the hardcoded
placeholder, ensuring feature output paths resolve against the same repository
root used to seed fixtures.

---

694-703: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid duplicating the registration fixture contents.

The checked-in tests/bdd/fixtures/ncp-local-register-values.yaml is also the source copied by the feature, but this helper embeds a second YAML copy. Future fixture changes can leave the wiring test stale while it continues to pass. Load or copy the checked-in fixture instead of maintaining another inline version.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/bdd/godog_test.go` around lines 694 - 703, Update the fixture setup in
the relevant test flow around writeFixture so it reads or copies
tests/bdd/fixtures/ncp-local-register-values.yaml instead of embedding
duplicated YAML content. Remove the inline fixture definition while preserving
the existing destination filename and test wiring behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/bdd/godog_test.go`:
- Line 645: Update the environment setup in the wiring test to set REPO_ROOT
from suite.Config.RepoRoot instead of the hardcoded placeholder, ensuring
feature output paths resolve against the same repository root used to seed
fixtures.
- Around line 694-703: Update the fixture setup in the relevant test flow around
writeFixture so it reads or copies
tests/bdd/fixtures/ncp-local-register-values.yaml instead of embedding
duplicated YAML content. Remove the inline fixture definition while preserving
the existing destination filename and test wiring behavior.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 05fc3c38-cd49-4191-9e8f-54232322cddf

📥 Commits

Reviewing files that changed from the base of the PR and between 6a8ed21 and ba85cb9.

📒 Files selected for processing (3)

• tests/bdd/features/observability-disabled.feature
• tests/bdd/fixtures/ncp-local-register-values.yaml
• tests/bdd/godog_test.go

[sbaum1994]

Rebased onto main at 2f7410fb.

Stack impact review:

• The shared observability stack and compute-plane observability gates did not change.
• The self-managed stack now requires state-metrics for control and all, adds an explicit autoscaler dependency on state-metrics, sources the autoscaler image from chart appVersion, and uses the OpenBao-rendered bearer token.
• Those changes are guarded by the enabled autoscaler profiles and do not affect observability.profile: disabled.
• OpenBao injector default changes are independent of the disabled observability render.

No BDD source update was needed. Validation after the rebase:

• make -C deploy/stacks/self-managed help
• focused disabled-profile wiring test
• go test -short ./...
• golangci-lint: 0 issues
• live TestObservabilityDisabled: passed in 57.479s

The rebase also removed the historical merge/#509 development ancestry from this branch and retained only PR1's three signed commits.