Skip to content

Skip kata manager processing#2407

Open
rajatchopra wants to merge 4 commits into
NVIDIA:mainfrom
rajatchopra:deprecatekatamanager
Open

Skip kata manager processing#2407
rajatchopra wants to merge 4 commits into
NVIDIA:mainfrom
rajatchopra:deprecatekatamanager

Conversation

@rajatchopra

@rajatchopra rajatchopra commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Description

Do not process anything about kata manager. The operand stands deprecated. Any changes to cluster policy with respect to that section must not be responded to. Remove it from state manager.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Manual testing on cluster with kataManager enabled=true manually on the CRD.
Prior to this fix, there is a panic in the logs. After the fix in this PR, it runs clean.

@rajatchopra rajatchopra changed the title do not process any kata manager [Draft][WIP]: do not process any kata manager Apr 27, 2026
@rajatchopra

Copy link
Copy Markdown
Contributor Author

Fixes #2398

@rajatchopra rajatchopra changed the title [Draft][WIP]: do not process any kata manager Skip kata manager processing Apr 28, 2026
Comment thread controllers/state_manager.go
Comment thread controllers/object_controls.go
Comment thread controllers/state_manager.go
Comment thread controllers/object_controls.go Outdated
Comment thread controllers/object_controls.go Outdated
Comment thread controllers/object_controls.go Outdated
@rajatchopra rajatchopra force-pushed the deprecatekatamanager branch from ad3fea3 to 87a65f9 Compare April 28, 2026 19:43
@rajatchopra rajatchopra force-pushed the deprecatekatamanager branch 2 times, most recently from 72a6f85 to 7419b11 Compare June 15, 2026 19:47
Comment thread controllers/object_controls.go Outdated
@rajatchopra rajatchopra force-pushed the deprecatekatamanager branch 2 times, most recently from 31de6ea to bbfb1e7 Compare June 23, 2026 22:40
Comment thread controllers/object_controls.go Outdated
Comment thread controllers/object_controls.go Outdated
@copy-pr-bot

copy-pr-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

… enabled=false

remove kata manager transformation test
keep the state added, but return false on the enabled call

Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
…ailure

Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
@rajatchopra rajatchopra force-pushed the deprecatekatamanager branch from 01e72c0 to 4a8eceb Compare July 2, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants