Skip kata manager processing#2407
Open
rajatchopra wants to merge 4 commits into
Open
Conversation
rajatchopra
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
rajatchopra
changed the title
Contributor
Author
|
Fixes #2398 |
rajatchopra
changed the title
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
rajatchopra
force-pushed
the
deprecatekatamanager
branch
from
ad3fea3 to
87a65f9
Compare
rajatchopra
force-pushed
the
deprecatekatamanager
branch
2 times, most recently
from
72a6f85 to
7419b11
Compare
rajatchopra
force-pushed
the
deprecatekatamanager
branch
2 times, most recently
from
31de6ea to
bbfb1e7
Compare
| if err != nil { | ||
| logger.Info("Couldn't update", "Error", err) | ||
| return gpuv1.NotReady, err | ||
| return gpuv1.NotReady, fmt.Errorf("error deleting kata RuntimeClass '%s': %v", rc.Name, err) |
Contributor
There was a problem hiding this comment.
Should we just log a warning if deletion fails? I'm not sure this warrants returning an error and setting ClusterPolicy status to NotReady.
Contributor
Author
There was a problem hiding this comment.
Yes I thought about it. I am in two minds.
But it should reconcile eventually, or if it is a permanent issue (that we can list and filter the runtimeclasses and not delete them for some reason) - then I believe we should bubble the error forth.
Contributor
There was a problem hiding this comment.
My reasoning for just logging a warning is that this deletion shouldn't block normal reconciliation. I don't think failure to delete these objects has an adverse effect. Not a strong opinion though.
Contributor
Author
There was a problem hiding this comment.
Fixed. Just a logger level 1 message and no break.
| // KataManagerAnnotationHashKey is the annotation indicating the hash of the kata-manager configuration | ||
| KataManagerAnnotationHashKey = "nvidia.com/kata-manager.last-applied-hash" | ||
| // DefaultKataArtifactsDir is the default directory to store kata artifacts on the host | ||
| DefaultKataArtifactsDir = "/opt/nvidia-gpu-operator/artifacts/runtimeclasses/" |
Contributor
There was a problem hiding this comment.
Should this be removed as well?
… enabled=false remove kata manager transformation test keep the state added, but return false on the enabled call Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
…ailure Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
rajatchopra
force-pushed
the
deprecatekatamanager
branch
from
01e72c0 to
4a8eceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not process anything about kata manager. The operand stands deprecated. Any changes to cluster policy with respect to that section must not be responded to. Remove it from state manager.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual testing on cluster with kataManager enabled=true manually on the CRD.
Prior to this fix, there is a panic in the logs. After the fix in this PR, it runs clean.