fix(FwPartitionDeviceLib): fix GPT overlap check - #164
Open
bobm21 wants to merge 1 commit into
Open
Conversation
NS instances that proxy writes through MM use an offset of zero for every partition. The GPT overlap validation can therefore reject valid inactive partition updates. Always derive candidate bounds from the GPT. Perform overlap checks and offset updates only on the side that owns the GPT. Signed-off-by: Bob Morgan <bobm@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NS instances that proxy writes through MM use
an offset of zero for every partition. The GPT
overlap validation can therefore reject valid
inactive partition updates.
Always derive candidate bounds from the GPT.
Perform overlap checks and offset updates only on
the side that owns the GPT.