Skip to content

StormScope: Return only lead_time=0 from ICs - #1117

Open
swbg wants to merge 2 commits into
mainfrom
stefan/fix-stormscope-ic
Open

StormScope: Return only lead_time=0 from ICs#1117
swbg wants to merge 2 commits into
mainfrom
stefan/fix-stormscope-ic

Conversation

@swbg

@swbg swbg commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Earth2Studio Pull Request

Description

The StormScope default generator previously returned all 6 lead times from the IC tensor. This did not match the returned coords (sliced to lead time 0) or the tensor/coords returned during forecast steps (only latest lead time)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.
  • Assess and address Greptile feedback (AI code review bot for guidance; use discretion, addressing all feedback is not required).

Dependencies

@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR corrects StormScope’s initial-condition generator so its tensor contains only the final history slice, matching the reported lead-time-zero coordinates.

  • Narrows the initial-condition tensor along its coordinate-defined lead_time axis.
  • Preserves spatial validity masking on the narrowed output.
  • Documents the fix in the changelog.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The narrowed tensor retains the expected dimension order, selects lead time zero, broadcasts correctly against the spatial validity mask, and now matches the single-value lead-time coordinates.

Important Files Changed

Filename Overview
earth2studio/models/px/stormscope.py Correctly narrows the initial-condition tensor to the last lead-time slice while preserving coordinate alignment and broadcast-compatible validity masking.
CHANGELOG.md Accurately records the StormScope initial-condition lead-time fix.

Reviews (1): Last reviewed commit: "update changelog" | Re-trigger Greptile

@NickGeneva

Copy link
Copy Markdown
Collaborator

Thanks @swbg ! I believe we have this fixed on the RC branch but haven't merged it onto main yet... I'll keep this open until then

#1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants