StormScope: Return only lead_time=0 from ICs - #1117
Open
swbg wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryThe PR corrects StormScope’s initial-condition generator so its tensor contains only the final history slice, matching the reported lead-time-zero coordinates.
|
| Filename | Overview |
|---|---|
| earth2studio/models/px/stormscope.py | Correctly narrows the initial-condition tensor to the last lead-time slice while preserving coordinate alignment and broadcast-compatible validity masking. |
| CHANGELOG.md | Accurately records the StormScope initial-condition lead-time fix. |
Reviews (1): Last reviewed commit: "update changelog" | Re-trigger Greptile
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earth2Studio Pull Request
Description
The StormScope default generator previously returned all 6 lead times from the IC tensor. This did not match the returned coords (sliced to lead time 0) or the tensor/coords returned during forecast steps (only latest lead time)
Checklist
Dependencies