Skip to content

Fix version dropdown menu by copying nv-versions.json files - #886

Merged
leofang merged 2 commits into
mainfrom
copilot/fix-885
Aug 21, 2025
Merged

Fix version dropdown menu by copying nv-versions.json files#886
leofang merged 2 commits into
mainfrom
copilot/fix-885

Conversation

Copilot AI commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

The version dropdown menu in the documentation was broken because the build scripts were missing the step to copy nv-versions.json files to the build output directory.

The issue occurred because:

  • The documentation configuration files (conf.py) reference nv-versions.json files for the version switcher functionality
  • The build scripts (build_docs.sh) were only copying versions.json files, not the required nv-versions.json files
  • This caused the version dropdown menu to fail to load the version information

The fix adds a single line to each of the three build scripts to copy the nv-versions.json file alongside the existing versions.json copy:

# to support version dropdown menu
cp ./versions.json build/html
cp ./nv-versions.json build/html  # Added this line

This ensures that the version switcher has access to the correct JSON files that contain the version information with proper URLs for navigation between different documentation versions.

Fixes #885.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
Copilot AI changed the title [WIP] BUG: Version dropdown menu is broken Fix version dropdown menu by copying nv-versions.json files Aug 21, 2025
Copilot AI requested a review from leofang August 21, 2025 21:39
@leofang leofang added bug Something isn't working documentation Improvements or additions to documentation P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Aug 21, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Aug 21, 2025
@leofang

leofang commented Aug 21, 2025

Copy link
Copy Markdown
Member

Let me admin-merge this to land the fix sooner.

@leofang
leofang marked this pull request as ready for review August 21, 2025 21:40
@leofang
leofang merged commit 1c03383 into main Aug 21, 2025
6 checks passed
@leofang
leofang deleted the copilot/fix-885 branch August 21, 2025 21:40
@github-project-automation github-project-automation Bot moved this from Todo to Done in CCCL Aug 21, 2025
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module documentation Improvements or additions to documentation P0 High priority - Must do!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

BUG: Version dropdown menu is broken

2 participants