Skip to content

[no-ci] Update the contributor guide - #3292

Open
leofang wants to merge 2 commits into
NVIDIA:mainfrom
leofang:rewording
Open

leofang wants to merge 2 commits into
NVIDIA:mainfrom
leofang:rewording

Conversation

@leofang

@leofang leofang commented Oct 30, 2026

Copy link
Copy Markdown
Member

Description

as per discussion on Thursday team sync

closes

Checklist

  • I have read the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang added this to the cuda.core 1.3.0 milestone Oct 30, 2026
@leofang
leofang requested a review from rwgk October 30, 2026 01:44
@leofang leofang self-assigned this Oct 30, 2026
@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! labels Oct 30, 2026
@leofang leofang changed the title Update the contributor guide [no-ci] Update the contributor guide Oct 30, 2026
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidelines to require maintainer assignment before external contributors begin work on existing issues. New work requires issue discussion, agreement on scope and validation, and assignment before implementation.
    • Obvious issues may be tracked with a brief issue. Bug reports should include a reproducer and environment details.
    • Unsolicited pull requests may be closed without notice. NVIDIA contributors may continue using normal team planning and self-assignment.
    • Removed the previous allowance for direct pull requests for small standalone fixes and for unassigned bug reports or suggestions.

The contribution guidance updates assignment requirements for external contributors, specifies information to include in bug reports, and states that unsolicited pull requests may be closed. NVIDIA contributors retain the self-assignment process.

Changes: Contribution guidance

Layer / File(s) Summary
External contributor process
CONTRIBUTING.md
External contributors must wait for assignment before implementing existing issues or new work. Bug reports should include a reproducer, expected and observed behavior, CUDA driver version, and Python environment information. The guidance states that unsolicited pull requests may be closed and retains NVIDIA contributor self-assignment.

Possibly related PRs

  • NVIDIA/cuda-python#3103: Updates contributor coordination rules, including maintainer agreement and assignment for external contributors.

Priority: Low

Change: Other

Merge Risk: Minimal · up to dd5fa

The contributor-guide change is ready for normal checks; the previously blocking whitespace has been fixed.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7743220 and 0d9f262.

Files selected for processing: 1
  • CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Comment thread CONTRIBUTING.md Resolved
@leofang leofang added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module labels Oct 30, 2026
@leofang
leofang requested review from mdboom and rparolin October 30, 2026 20:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module documentation Improvements or additions to documentation P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant