Set CU_CTX_SCHED_BLOCKING_SYNC option in tests. - #1209
Conversation
22e42c2 to
c301d9c
Compare
|
Q: Why is this needed? We don't expect our users to do this. |
|
This is not essential. It just reduces load on the test machines. I was annoyed by the spinning when working with certain multiprocessing tests and happened to come across this option in the docs. It's a 5-minute change so I figured why not. |
|
/ok to test c301d9ceb070e002ba1e427b773600e0ddf5fcc6 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
This is not essential. It just reduces load on the test machines.
Then we should not make this change. We need to test the real-life use scenarios. With the upcoming coverage of various Windows driver modes (#985) our test env will get more sensitive to the underlying driver than ever. Changing the global state is not helping if any issue comes up.
This is why I kept pushing for IPC events so as to enabling stream-ordered IPC tests. Device synchronization is expansive at the library test scale. We should avoid writing tests that require synchronization. We've had enough in the past to learn in a hard way that stream ordering is critical 😅 |
|
I'll take a look at the performance issue. @Andy-Jost do you have in mind speeding up the aggregate performance of all tests under |
|
Let me clarify: I'm not saying there's any performance issue. The annoyance I ran into was during development, especially while using I believe most of the wait in |
|
I would be OK if you could guard this change behind a test-time env var (say, |
c301d9c to
b867b3b
Compare
|
Sounds good. Latest upload adds an environment variable guard. |
|
/ok to test b867b3b |
Co-authored-by: Leo Fang <leo80042@gmail.com>
bf8295c to
e86d5b7
Compare
|
/ok to test e86d5b7 |
|
By default, CPU threads spin while waiting for GPU synchronization. This changes the option to block instead while testing.
See cuDevicePrimaryCtxSetFlags for details.