[NVVM] Guardrail test_program for version mismatches between driver and PTX compiled binary - #1204
Merged
Merged
Conversation
Contributor
Contributor
Author
|
pre-commit.ci autofix |
Member
|
/ok to test dd78838 |
leofang
reviewed
Oct 31, 2025
| except CUDAError as e: | ||
| if re.search(r"CUDA_UNSUPPORTED_PTX_VERSION", str(e)): | ||
| pytest.xfail("PTX version not supported by current CUDA Driver") | ||
| raise |
Member
There was a problem hiding this comment.
Q: Shouldn't this be
Suggested change
| raise | |
| else: | |
| raise |
Contributor
There was a problem hiding this comment.
The else isn't needed: pytest.xfail exits the test right at the call site.
But the else doesn't do harm either.
I tend to fully rely on the pytest behavior, i.e. not add redundant flow control, for more compact code.
This comment has been minimized.
This comment has been minimized.
rwgk
approved these changes
Oct 31, 2025
leofang
enabled auto-merge (squash)
October 31, 2025 16:37
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Internal NVBug: 5623403
Currently test_program.py does not have an exception case to handle mismatch in PTX compiled binary supported version and driver version, in order to prevent running of compiled PTX code on older drivers .
@rwgk @leofang please help to review, thanks.