fix(inference): skip generation VAE for reasoner-only runs#132
Open
chrisvoncsefalvay wants to merge 2 commits into
Open
fix(inference): skip generation VAE for reasoner-only runs#132chrisvoncsefalvay wants to merge 2 commits into
chrisvoncsefalvay wants to merge 2 commits into
Conversation
Detect all-reasoner CLI batches before model construction and disable only the generation vision tokenizer. Keep mixed and generative workloads on the existing eager path.
Use configured compression factors for token-budget batching when the generation tokenizer is absent, and treat separate vision decode GPU placement as a no-op in that state.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoner-only CLI inference to no longer instantiate the generation vision tokeniser or resolves the video VAE. Mixed and generative input sets retain the existing eager-loading behaviour.
Root cause
OmniMoTModel.set_up_tokenizersinstantiatedmodel.config.tokenizerunconditionally. For Cosmos3-Edge, that tokeniser resolvesWan2.2_VAE.pth, even when inference only produces reasoner text.Changes
model.config.load_vision_tokenizer=falseoverrideBehaviour
load_vision_tokenizerdefaults totrue.Fixes #128