Repository navigation
review: add severity exit threshold - #39
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9 by adding an opt-in severity gate to
boro reviewwhile preserving the existing default exit behavior. The JSON output already carriesschema_version: 1; this PR documents that contract alongside the new CI/pre-send integration option.Changes
review --fail-on=critical|high|medium|low.1when surviving findings meet or exceed the selected threshold.validated_findingswhen available, otherwise use finalfindings.Testing
cargo fmt -- --check— passed.cargo test cli_tests— 20 passed.cargo test— 451 unit tests passed; integration tests had 4 passed and 1 pre-existing failure inapply_message_id_handles_one_patchdue to its existing quoted-path expectation.cargo test --test apply_range_cli apply_single_commit_keeps_schema_v1— passed.cargo clippy --all-targets --all-features -- -D warnings— blocked by 19 pre-existing warnings in unrelated files; no warning was reported for the changed code.Notes
The threshold is intentionally opt-in and applies after final validation, so it does not change existing review results or default exit codes.
--jsonoutput is still emitted before the non-zero exit status, making the result suitable for CI artifact capture.This contribution was prepared with AI assistance and manually checked against the repository's source, tests, and command output.