Skip to content

sdk: derive facade Criteria from Snapshot #2437

Description

@mchmarny

Summary

The documented snapshot-to-recipe path still imports internal pkg/fingerprint and evolving pkg/recipe. This contradicts #2016's acceptance bar that an integrator can complete the workflow using only pkg/client/v1.

Proposed change

Add a facade-owned snapshot-to-criteria operation returning *aicr.Criteria and using the Client's provider-scoped criteria registry. Route the CLI and compiled example through it.

Acceptance criteria

  • Snapshot-derived criteria require only pkg/client/v1.
  • The CLI no longer imports pkg/fingerprint for this workflow.
  • The integrator guide removes the unstable-package escape hatch.
  • New surface is stability-pinned and API-diff covered.
  • Tests cover nil/invalid snapshots and representative provider/GPU criteria.

Parent: #2016

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions