Repository navigation
fix(p6): avoid target-word matches inside longer identifiers - #815
Draft
chrisknvidia wants to merge 2 commits into
Draft
chrisknvidia wants to merge 2 commits into
chrisknvidia wants to merge 2 commits into
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P6 reports HIGH from the truncated
return PROMPTmatch insidereturn PROMPT_INJECTION_PATTERNS. Camelcase and other identifier continuations have the same problem.Require complete terminal target nouns in P6, including across normalized text, declared-marker reconstruction, and overlapping scan windows. Keep genuine protected-prompt extraction detectable, including complete plural/configuration nouns and intentionally reconstructed requests. Preserve mapped source locations and use a bounded per-artifact provenance cache with the runner's directive ownership and runtime callback.
Related to #523. Ordinary full-word local
return promptprovenance remains outside this focused change; this PR does not close the broader issue.Validation:
src/,tests/) and 142 focused tests pass.59f14e4966f3170b0b0d738d1de42e873efb5ce6, GitHub lint, DCO, OpenCode TypeScript and Docker smoke pass; the full unit job is still running.Complete plural/configuration matches now include the whole target noun, so baselines keyed to formerly truncated match text may need regeneration. Singular complete-target baseline compatibility was verified separately.
This remains draft while full unit CI is pending and the required native Bugbot and Security Review passes are unavailable. The manual review and RG/TG do not substitute for those passes. No provider-backed model or hosted consumer pipeline validation has been performed.