Skip to content

test(features): add CDI injection scenarios for Docker and Podman #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elezar wants to merge 5 commits into
base: main
Choose a base branch
from
+1,493 −111
Open

test(features): add CDI injection scenarios for Docker and Podman #4461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76e27d1
refactor(tmachine): compose feature environments from base environments
elezar Nov 5, 2026
49ff71b
test(tmachine): let environments add gateway driver settings
elezar Nov 5, 2026
3c42653
test(tmachine): add CDI fixtures and cdi feature environments
elezar Nov 5, 2026
d5a0244
test(features): add the CDI suite with the read-only baseline scenario
elezar Nov 5, 2026
2f2907b
test(features): add the remaining CDI scenarios
elezar Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/e2e-suites.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ jobs:
{"environment":"fedora-podman-rootless","installer":"rpm","family":"conformance","package":"conformance","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"ubuntu-k3s","installer":"k3s","family":"conformance","package":"conformance","gateway":"tmachine","runner":"ubuntu-24.04"},
{"environment":"ubuntu-k3s","installer":"k3s-ha","family":"conformance","package":"conformance","gateway":"tmachine","runner":"ubuntu-24.04"},
{"environment":"ubuntu-docker-rootful-cdi","installer":"deb","family":"features","package":"cdi","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"fedora-podman-rootful-cdi","installer":"rpm","family":"features","package":"cdi","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"fedora-podman-rootless-cdi","installer":"rpm","family":"features","package":"cdi","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"ubuntu-docker-rootful-keycloak","installer":"deb","family":"features","package":"keycloak-provider-refresh","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"ubuntu-docker-rootful","installer":"deb","family":"features","package":"oci-image","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"fedora-podman-rootful","installer":"rpm","family":"features","package":"oci-image","gateway":"openshell","runner":"ubuntu-24.04"},
Expand Down
9 changes: 9 additions & 0 deletions TESTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,15 @@ nix run .#openshell-test-runner -- \
--family features --package keycloak-provider-refresh
```

A suite that needs setup beyond a container engine runs in a feature
environment, named `<base>-<feature>`, such as `ubuntu-docker-rootful-keycloak`
or `ubuntu-docker-rootful-cdi`. `features` in `tests/tmachine/config.nix` lists
each feature's setup playbooks, the inputs they read, and the bases it supports.
To add one, add an entry there and use the generated environment name in the
suite's row in `.github/workflows/e2e-suites.yml`. The CDI suite
(`tests/suites/features/cdi`) runs in `ubuntu-docker-rootful-cdi`, which creates
hardware-free CDI devices and the host files they reference.

### Python E2E (`e2e/python/`)

`mise run e2e:python` builds `openshell/e2e-python:dev` from
Expand Down
8 changes: 8 additions & 0 deletions tests/suites/features/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/suites/features/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

[workspace]
resolver = "2"
members = ["host-gateway", "keycloak-provider-refresh", "kubernetes-updates", "oci-image"]
members = ["cdi", "host-gateway", "keycloak-provider-refresh", "kubernetes-updates", "oci-image"]
16 changes: 16 additions & 0 deletions tests/suites/features/cdi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

[package]
name = "cdi"
description = "Features suite: CDI device injection"
version = "0.0.0"
edition = "2024"
rust-version = "1.94"
license = "Apache-2.0"
repository = "https://github.com/NVIDIA/OpenShell"
publish = false

[dependencies]
openshell-testkit = { path = "../../../testkit/testkit" }
serde_json = "1"
Loading
Loading