fix(policy): propose rules for unknown DNS hosts - #3707
Merged
Merged
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 25, 2026 06:11
|
🌿 Preview your docs: https://nvidia-preview-pr-3707.docs.buildwithfern.com/openshell |
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
- Emit the policy_dns_ineligible denial for every unknown name and report observation staging failures as DNS failure events. - Refuse unknown names during fail-closed quarantine and after the observation budget, now a quarter of each address family's pool. - Pin transparent TCP to the mapping of the deciding policy generation so a reload between DNS and authorization fails closed. - Stop Docker workloads from inheriting host DNS search domains, which let the first expanded short name claim an observation address. - Share mechanistic draft polling in conformance, register new-hostname-proposal in the installed suite, and update docs. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
|
Label |
pimlock
commented
Sep 25, 2026
The proxy tests name PolicyEndpointId, which proxy.rs imported only on Linux, so the macOS test build failed. Import it for test builds too. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
DNS denial and failure events attached port 53 to the queried name, which read as a connection to that host. They now carry only the name. Transparent TCP denials for a policy DNS address show the mapped hostname and keep the synthetic address in dst_endpoint.ip. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
commented
Sep 25, 2026
drew
approved these changes
Sep 25, 2026
jakolehm
added a commit
to jakolehm/OpenShell
that referenced
this pull request
Sep 25, 2026
Merge upstream 9244868, including NVIDIA#3707, while retaining the opt-in per-connection approval hook and deferred DNS path. Keep deferred approvals distinct from non-authorizing observations, share the unknown-name budget, and retain reserved-name, quarantine, and policy-generation guards. Policy-changing approvals require a new DNS lookup and connection retry. Validation: 1365 network tests passed (2 ignored); network all-target Clippy passed on Rust 1.95. Full mise gates were attempted but blocked by unavailable uv/sccache tooling and an installer shell test error. Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix missing mechanistic policy proposals when a sandbox requests a hostname absent from its network policy. Policy DNS now stages a contract-free synthetic observation so TCP mediation can capture the host, port, and verified binary, deny the connection, and send the denial to the mapper, even with agent-authored proposal settings unset. Docker workloads also stop inheriting host DNS search domains, because an observation answer for the first search-expanded name would otherwise shadow the name the workload asked for.
Related Issue
No issue required: this fixes the observed missing proposal for unknown DNS names in the existing policy DNS and policy advisor flow (related feature: #2712).
Changes
policy_dns_ineligibleDNS denial, and a failed staging attempt emits a DNS failure event.REFUSEDanswer for reserved names (localhost, metadata, and host-gateway aliases), during fail-closed policy quarantine, and after the observation budget is spent. Observations may hold at most a quarter of each address family's synthetic pool (up to 128 names per family for the supervisor lifetime), and their addresses are never reused.host:53, which read as a connection to that host. Transparent TCP denials for a policy DNS address show the mapped hostname and keep the synthetic address indst_endpoint.ip.dns_searchset to.), matching the Podman, Kubernetes, and VM resolver configuration.new-hostname-proposalconformance scenario and register it in the installed-artifactpolicy-advisorsuite. Both proposal scenarios share draft polling that tolerates transientrule getfailures and requires a single draft scoped to the expected host, port, and binary.CI.md, and the policy advisor e2e README.Testing
mise run pre-commitpasses.Checklist