Conversation
Clear the chart-wide registry when the Kubernetes wrapper supplies explicit image components so unqualified local images do not inherit the released GHCR registry. Fixes: NVIDIA#3696 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
danehans
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 25, 2026 02:57
9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve unqualified local OpenShell image overrides in Kubernetes E2E runs by clearing the chart-wide release registry when the wrapper supplies explicit image components.
Related Issue
Fixes #3696
Changes
global.image.registryin the Kubernetes E2E Helm arguments.Testing
mise run pre-commitpassesmise run test:e2e-image-overridespassesbash -n e2e/with-kube-gateway.shpassesChecklist