Skip to content

docs: correct stale install, logging, runtime, and TCP details - #3699

Closed
johnnygreco wants to merge 3 commits into
mainfrom
docs/fix-stale-runtime-details/jg
Closed

johnnygreco wants to merge 3 commits into
mainfrom
docs/fix-stale-runtime-details/jg

Conversation

@johnnygreco

@johnnygreco johnnygreco commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Corrects documentation outside the Policies section that no longer matches the code, plus the CLI's approval-mode retry hint. These fixes are independent of the policy documentation rewrite in #3563, which includes the related GitHub tutorial log fix.

Related Issue

No issue required: small documentation fixes that align existing pages with current behavior, and a one-line correction to a CLI hint.

Changes

  • docs/about/installation.mdx: The install script no longer claims to always install the policy prover. The snap package ships only openshell, term, and gateway (snapcraft.yaml), and the script uses the snap on Linux when snap is available and OPENSHELL_VERSION is unset or dev. The page now says the Homebrew, Debian, and RPM packages install openshell-prover and points snap users to the release archives that release-tag.yml publishes.
  • docs/sandboxes/inference-routing.mdx: Replaces /usr/bin/python3 and /usr/local/bin/python in the example profile with /usr/bin/python3.* and /usr/local/bin/python3.*. Binary matching uses the kernel-reported real path, and the supervisor does not resolve symlinks in policy paths, so symlinked interpreter paths never match. After docs(policy): refresh policy documentation and references #3563 merges, this note can link to its new Binary Matching section.
  • docs/reference/sandbox-compute-drivers.mdx: Since RFC 0012 (feat(isolation): implement the RFC 0012 sandbox architecture #2942), the Docker, Podman, MicroVM, and Kubernetes drivers run the supervisor outside the workload, and openshell-sandbox launches the agent inside it.
  • crates/openshell-supervisor-process/src/skills/policy_advisor.md (in-sandbox agent guide): Uses --key and --value with openshell settings set, shows the auto-approval audit fields in shorthand form, and replaces the "Local logs" section. The supervisor writes /var/log/openshell*.log outside the workload, so the guide now points agents to GET /v1/denials.
  • crates/openshell-cli/src/run.rs: Fixes the approval-mode retry hint, which passed the setting key and value as positional arguments.
  • architecture/security-policy.md: Auto-approval fields appear as auto:true (not auto=true) in the shorthand log, and source records the proposer (mechanistic or agent_authored).
  • architecture/sandbox.md: Describes transparent connections as they work today. The supervisor replays each captured connect as a virtual CONNECT through the same relay selection, so it terminates TLS unless the endpoint sets tls: skip, and protocol: tcp adds no request rules without bypassing TLS handling. Policy DNS covers endpoints of every protocol.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)
  • mise run docs passes (0 errors; its three warnings also occur on main)
  • Checked each corrected statement against the current code.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

`openshell settings set` takes the setting key and value through the
`--key` and `--value` flags. The retry hint that `sandbox create
--approval-mode` prints when it cannot persist the setting passed them as
positional arguments, which the CLI rejects.

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
- installation: the snap package does not include openshell-prover. Say
  that the Homebrew, Debian, and RPM packages install it, and point snap
  users to the release archives.
- github-sandbox tutorial: drop `--level warn`, which hides policy events,
  and show the OCSF shorthand line for the denied push.
- inference-routing: match versioned Python interpreters with globs.
  Binary matching uses the real executable path, not symlinks.
- sandbox runtimes: the Docker, Podman, MicroVM, and Kubernetes drivers
  run the supervisor outside the workload.
- in-sandbox policy advisor guide: use `--key` and `--value` with
  `openshell settings set`, show auto-approval fields in shorthand form,
  and explain that the activity logs live with the supervisor.
- architecture: render auto-approval fields as `auto:true`, and describe
  transparent connections as virtual CONNECTs that keep TLS handling.

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

The policy documentation rewrite (#3563) makes the same change to the
GitHub tutorial's log command and sample line. Restore the tutorial here
so the two pull requests do not conflict.

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Sep 25, 2026
@pimlock

pimlock commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 91baa44

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've got this covered here, #3705

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got this covered here, #3705

@johntmyers johntmyers closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants