Repository navigation
fix(e2e): accept bot-authored upgrade PRs for admission - #13273
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
deepujain
left a comment
There was a problem hiding this comment.
Thanks for the narrow fix. The regex accepts only a trailing [bot], the malformed-suffix test covers that, and the approver checks (human User, maintain/admin, exact head and base) are unchanged. Admission still requires a same-repository head branch, so fork PRs stay out. LGTM.
Verified on 007befd39: Core CI, Candidate Upgrade Admission, check-hash, growth limits, DCO, and title lint passed (63 succeeded, 23 skipped, 0 failed). CodeRabbit review completed. PR Review Advisor passed.
Outcome
Upgrade admission accepts a same-repository PR authored by a GitHub App bot. It still requires an approval from a different human with current
maintainoradminpermission, bound to the exact head and base commits.Reason
The trusted verifier on
mainrejects #12603 before it reads approvals because its author isnvidia-nemopatch-writer[bot]. This blocks candidate admission and check-hash even though the PR's repository, head, and base match the expected values.Related issues
Refs #12603.
Changes
[bot]suffix only when parsing the PR author's login. Keep the existing human login and account-type checks for approvers.Verification
npx vitest run --project e2e-support test/e2e/support/candidate-upgrade-admission.test.ts— 46 tests passed after rebasing onto currentmain.npm run checks:repository— all 18 checks passed.npm run docs— 0 errors, 2 warnings.git diff --check— passed.pre-commit,commit-msg, andpre-pushhooks — passed. The pre-push hook ran through a credential restricted macOS sandbox while SSH transport stayed outside it.Review notes
tools/e2e/candidate-upgrade-admission.mtsis a sensitive enforcement path. An independent documentation writer reviewed the code, tests, and README for writing and documentation accuracy: PASS, no findings. The trusted verifier change still awaits independent maintainer review. This draft does not claim approval or successful live E2E.Signed-off-by: Prekshi Vyas prekshiv@nvidia.com
Summary by CodeRabbit