fix(onboard): prepare Jetson images before GPU probes - #11877
latenighthackathon wants to merge 1 commit into
Conversation
Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughChangesGPU image preparation
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant createDockerLifecycle
participant ImagePreparation
participant Docker
participant GPUProbe
createDockerLifecycle->>ImagePreparation: Prepare image for Jetson or WSL
ImagePreparation->>Docker: Pull image with 30-minute limit
createDockerLifecycle->>GPUProbe: Select GPU mode after preparation
GPUProbe->>Docker: Probe with pullPolicy never and 30-second timeout
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Jetson image preparation is moved before the bounded GPU probe, while cached images and pull-timeout behavior remain covered. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 215b36d in the TypeScript / code-coverage/cliThe overall line coverage in commit 215b36d in the Show a line coverage summary of the most impacted files.
Updated |
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
|
Thanks for the focused fix and test coverage. We are closing this PR because the accepted Jetson GPU direction now uses OpenShell-native CDI as the single authority for device injection, mounts, supplemental groups, and hardware-derived sandbox policy. This PR correctly prevents a cold image pull from consuming the bounded NemoClaw compatibility probe timeout. However, it changes the legacy Jetson compatibility probe and container-recreation path, which NemoClaw no longer intends to extend. PR #8910 owns NemoClaw adoption and qualification of the released OpenShell CDI contract. Issue #11677 will remain open and track that supported path. This closure does not mean that #8910 already contains this pre-pull change or that the reported behavior is fixed. |
Outcome
Jetson managed onboarding now prepares an uncached sandbox image before the 30-second GPU probe. Image downloads use the existing progress watchdog instead of consuming the probe timeout.
Reason
The image preparation path covered Docker Desktop WSL but not Jetson, which could misreport a slow image download as an NVIDIA runtime failure.
Related issues
Fixes #11677
Changes
Verification
Review notes
Self-review of
NVIDIA/NemoClawcommit215b36d4293daf4e3b07df66071a4c63d839ea13covered the managed-bootstrap lifecycle and affected tests. This reuses the existing digest-pinned image preparation and credential-cleanup paths. GPU admission, device permissions, and runtime ownership are unchanged.Tests ran in Linux with mocked Docker boundaries. No physical Jetson onboarding or CUDA qualification is claimed; this does not establish new platform support. Independent CI and automated review remain pending.
Signed-off-by: latenighthackathon latenighthackathon@users.noreply.github.com
Summary by CodeRabbit
Bug Fixes
Tests