docs(openshell): add NAT deployment guide#2075
Conversation
Signed-off-by: afourniernv <afournier@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds OpenShell as a supported framework in the existing-agents documentation index, introduces a new 546-line ChangesOpenShell Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/run-workflows/existing-agents/openshell.md`:
- Around line 514-518: In the responsibility table around line 514-518, replace
the header "NAT owns" with "NeMo Agent Toolkit owns" or "The Toolkit owns" to
comply with the documentation guideline that restricts the acronym NAT to code
contexts only. Update the header text while keeping the bullet point list
structure (workflow YAML, tool definitions, frontend behavior, tracing and
evaluation hooks, agent-specific auth adapters) intact, formatted as bold
markdown for the header followed by the bullet points.
- Around line 18-29: Replace all instances of "NAT" used to refer to the toolkit
product with either "NeMo Agent Toolkit" or "the toolkit" throughout the
document, reserving "NAT" for use only in code comments as per documentation
guidelines. Specific examples include: "run a NAT agent as a managed service"
should become "run a NeMo Agent Toolkit agent" or "run an agent", and "This
guide focuses on the NAT side of the integration. NAT still owns the workflow"
should become "This guide focuses on the NeMo Agent Toolkit side" or "the
toolkit side", with "the toolkit still owns" replacing the second instance.
Apply this replacement systematically across the entire document wherever NAT
appears in prose text.
- Around line 24-29: The documentation file
docs/source/run-workflows/existing-agents/openshell.md violates the naming
guideline by using "NAT" in prose sections to refer to the toolkit product.
Replace all "NAT" references with "NeMo Agent Toolkit" (on first mention) or
"the toolkit" (on subsequent mentions) across all prose content, while
preserving "NAT" only in code examples, package names, and code identifiers.
Apply the following replacements in
docs/source/run-workflows/existing-agents/openshell.md: at lines 24-29, replace
"run a NAT agent", "the NAT side", "NAT still owns"; at lines 37-38, replace
"NAT workload" and "The NAT image"; at line 80, update the heading to remove
"NAT Auth Providers"; at line 95, replace "NAT auth providers"; at line 104,
replace "NAT auth providers"; at line 108, replace "NAT-side auth shape"; at
line 118, replace "NAT consumes"; at line 194, replace "the NAT workload"; at
line 233, replace "the NAT workflow"; at line 314, replace "service-oriented NAT
entrypoint". Ensure consistency by using the full product name on first
reference and the shorter form "the toolkit" for subsequent references within
each section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7affce30-43c4-450b-a54d-5245103564f6
📒 Files selected for processing (3)
docs/source/run-workflows/existing-agents/index.mddocs/source/run-workflows/existing-agents/openshell.mdexamples/a365_example/README.md
|
/ok to test |
@afourniernv, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Signed-off-by: afourniernv <afournier@nvidia.com>
|
/ok to test 2164fa5 |
Signed-off-by: afourniernv <afournier@nvidia.com>
|
/ok to test ee4ff20 |
Summary
Add a guide for running NeMo Agent Toolkit workloads inside OpenShell, including a minimal example, auth-boundary guidance, outbound tool and MCP access, and local versus Kubernetes deployment lanes.
Related Issue
N/A
Changes
docs/source/run-workflows/existing-agents/openshell.mdTesting
PATH=/Users/afournier/proj/NeMo-Agent-Toolkit/.venv/bin:$PATH NAT_DISABLE_API_BUILD=1 sphinx-build -M html docs/source docs/build -j 4 --show-tracebackChecklist
Summary by CodeRabbit