Repository navigation
[26.04_linux-nvidia] NVIDIA: SAUCE: pinctrl: mt8901: sync wake EINT event mask - #635
Closed
kbutala-nv wants to merge 1 commit into
Closed
kbutala-nv wants to merge 1 commit into
kbutala-nv wants to merge 1 commit into
Conversation
Collaborator
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🟢 4/4 passed
Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ✅ All checks passedDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ 0f0aeba49253 │ [SAUCE] pinctrl: mt8901: sync wake eint event mask │ N/A │ N/A │ kbutala │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. |
Collaborator
Please add the following Please also add Launchpad #2170130 as the first line of the PR description. |
MT8901 EINT has a separate event mask that controls whether an EINT can be forwarded as a wake event. The current driver clears that mask only for the static SoC list, which covers the ACPI event line. Firmware-described devices can be marked wake-capable independently, so PM arms their IRQs through the normal irq_set_wake path. Clear the hardware event mask when the IRQ core enables such an EINT as a wake source so keyboard, touchpad, and other firmware-declared EINT wake sources can reach the SPM without adding board-specific EINT numbers. Restore the hardware event mask when wake is disabled, otherwise a pin that was armed once would remain an SPM wake event until reboot. Keep pins from the SoC static event-unmask list unmasked so permanently required wake events such as the ACPI event line remain armed. Make event-mask register programming opt-in for SoCs that declare support for it, and re-apply both the static list and dynamically armed wake_mask pins on resume in case the event register state is lost across system sleep. Fixes: 927eeda ("NVIDIA: SAUCE: pinctrl: mt8901: Enable ACPI wake-event EINT support") Signed-off-by: Kaushal Rajeev Butala <kbutala@nvidia.com>
Author
Done! |
Collaborator
|
|
nirmoy
added
has_2_acks
and removed
help wanted
Collaborator
|
Merged, closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LP: https://bugs.launchpad.net/bugs/2170130
MT8901 EINT has a separate event mask that controls whether an EINT can be forwarded as a wake event. The current driver clears that mask only for the static SoC list, which covers the ACPI event line.
Firmware-described devices can be marked wake-capable independently, so PM arms their IRQs through the normal irq_set_wake path. Clear the hardware event mask when the IRQ core enables such an EINT as a wake source so keyboard, touchpad, and other firmware-declared EINT wake sources can reach the SPM without adding board-specific EINT numbers.
Restore the hardware event mask when wake is disabled, otherwise a pin that was armed once would remain an SPM wake event until reboot. Keep pins from the SoC static event-unmask list unmasked so permanently required wake events such as the ACPI event line remain armed.
Make event-mask register programming opt-in for SoCs that declare support for it, and re-apply both the static list and dynamically armed wake_mask pins on resume in case the event register state is lost across system sleep.
Fixes: 927eeda ("NVIDIA: SAUCE: pinctrl: mt8901: Enable ACPI wake-event EINT support")
This is needed for internal bug 6839927