Repository navigation
[26.04_linux-nvidia] NVIDIA: SAUCE: watchdog: sbsa_gwdt: stop ping worker during system sleep - #632
Closed
bdintakurti-nv wants to merge 1 commit into
Conversation
Collaborator
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🟢 4/4 passed
Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ✅ All checks passedDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ 0fa2e333e898 │ [SAUCE] watchdog: sbsa_gwdt: stop mt8901 ping worker during susp │ N/A │ N/A │ bdintaku │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. |
Collaborator
|
No issues from me for this specific commit, however I did have a review finding that I shared in sibling PR 633 that should be addressed in a follow-on fix/series (acknowledged by Bharat in that PR).
|
bdintakurti-nv
force-pushed
the
sbsa-watchdog-stop-ping-on-suspend-26.04
branch
3 times, most recently
from
October 8, 2026 02:19
38ebfd6 to
a0966b5
Compare
Collaborator
|
Please add the following Please also wrap the commit-message body at 72 columns, keeping the Otherwise, this change looks fine to me. |
…spend On MediaTek SBSA watchdogs in action=1 mode, the sleep notifier parks the hardware watchdog, but the watchdog-core keepalive timer remains armed. Its SYS_TIMER interrupt can wake MT8901 from S3 even though the hardware watchdog is parked. Use the existing watchdog-core PM hook in this mode to cancel the ping worker during system sleep and restore it on resume. Leave action=0 unchanged: its WS0 heartbeat workaround needs separate resume-time accounting before its core worker can be quiesced. Fixes: 280db0e ("NVIDIA: SAUCE: watchdog: sbsa_gwdt: park the watchdog around system sleep on MediaTek implementations") Signed-off-by: Bharat Dintakurti <bdintakurti@nvidia.com>
bdintakurti-nv
force-pushed
the
sbsa-watchdog-stop-ping-on-suspend-26.04
branch
from
October 8, 2026 12:19
a0966b5 to
0fa2e33
Compare
Collaborator
|
|
Collaborator
|
|
nirmoy
added
has_2_acks
and removed
help wanted
Collaborator
|
Merged, closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MediaTek SBSA watchdogs in action=1 mode, the sleep notifier parks the hardware during system sleep, but the watchdog-core keepalive timer can remain armed. Its SYS_TIMER interrupt can wake MT8901 from S3 even though the hardware watchdog is parked.
This change opts only that mode into the existing watchdog-core suspend hook, canceling the ping timer and work at PM prepare and restoring the worker on resume. action=0 remains unchanged because its WS0 heartbeat workaround needs separate resume-time accounting. The watchdog core's existing prepare-to-freeze rearm window is outside this PR's scope.
Validation: On MT8901 with action=1, early_enable=1, and a 10-second timeout, three 60-second deep S3 cycles with TAD wake resumed without an early SYS_TIMER wake or watchdog reset. The boot ID was unchanged.
Follow-up to #627.
BugLink: https://bugs.launchpad.net/bugs/2169002