Type hint cleanup in transcribe_utils#15844
Open
TeamInfinixdevcom wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add missing type annotations in nemo/collections/asr/parts/utils/transcribe_utils.py without changing runtime behavior, improving readability and (where used) static analysis of ASR transcription utilities.
Changes:
- Added
Optional[...]annotations for several optional parameters (e.g.,manifest,output_manifest_path,filepaths). - Added/adjusted return types for a few helpers (e.g.,
restore_transcription_order,normalize_timestamp_output) and annotated__init__to returnNone. - Updated typing imports to include
Dict.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+222
to
+223
| manifest: Optional[str] = None, | ||
| filepaths: Optional[List[list]] = None, |
|
|
||
|
|
||
| def normalize_timestamp_output(timestamps: dict): | ||
| def normalize_timestamp_output(timestamps: Dict) -> Dict: |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Team Infinix Dev <teaminfinixdev@gmail.com>
svcnvidia-nemo-ci
added
the
waiting-on-maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: added the missing type annotations in nemo/collections/asr/parts/utils/transcribe_utils.py without changing behavior. The fix is already validated, committed, and pushed.