fix(grpo): apply effort shaping to async Gym rollouts - #3897
Merged
Conversation
Legacy async GRPO forwarded reward penalties to NeMo Gym rollout postprocessing but omitted the configured effort levels. As a result, training silently skipped length-based effort shaping even though synchronous rollouts and validation applied it. Resolve the existing validated effort config in the async trajectory collector and pass it to every NeMo Gym stream attempt. Add regression coverage at the collector-to-rollout boundary, including the retry path. Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> (cherry picked from commit fbc6a88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super-v3.5-posttraining.length_penalty_configwiring from feat: super v3.5 posttraining with flexible length penalties #3852.Source commit:
fbc6a8811835747e9e602df1df26288186a26eb8Validation
pre-commit run --all-files— passedgit diff --check— passed