fix(ci): set CUDA major for torch-memory-saver lock generation - #3862
Merged
Conversation
Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shanmugamr1992
approved these changes
Aug 27, 2026
kajalj22
approved these changes
Aug 27, 2026
Contributor
|
/ok to test 2e555db |
balasaajay
enabled auto-merge (squash)
August 27, 2026 00:19
Contributor
Author
|
/ok to test f08a3f2 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
torch-memory-saver requires TMS_CUDA_MAJOR when uv invokes its build
backend during lockfile generation. Derive it from the configured CUDA
base image to avoid hardcoding and keep it aligned with the container.
fixes: https://github.com/NVIDIA-NeMo/RL/actions/runs/33016571935/job/98337729453
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information