Skip to content

fix(ci): set CUDA major for torch-memory-saver lock generation - #3862

Merged
balasaajay merged 2 commits into
NVIDIA-NeMo:mainfrom
balasaajay:fix-torchmemsaver-issue
Aug 28, 2026
Merged

fix(ci): set CUDA major for torch-memory-saver lock generation#3862
balasaajay merged 2 commits into
NVIDIA-NeMo:mainfrom
balasaajay:fix-torchmemsaver-issue

Conversation

@balasaajay

Copy link
Copy Markdown
Contributor

What does this PR do ?

torch-memory-saver requires TMS_CUDA_MAJOR when uv invokes its build
backend during lockfile generation. Derive it from the configured CUDA
base image to avoid hardcoding and keep it aligned with the container.

fixes: https://github.com/NVIDIA-NeMo/RL/actions/runs/33016571935/job/98337729453

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@balasaajay
balasaajay requested a review from a team as a code owner August 27, 2026 00:08
@copy-pr-bot

copy-pr-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI Relating to CI label Aug 27, 2026
@kajalj22 kajalj22 added the CI:L1 Run doctests, unit tests, and functional tests label Aug 27, 2026
@kajalj22

Copy link
Copy Markdown
Contributor

/ok to test 2e555db

@balasaajay
balasaajay enabled auto-merge (squash) August 27, 2026 00:19
@balasaajay

Copy link
Copy Markdown
Contributor Author

/ok to test f08a3f2

@balasaajay
balasaajay merged commit 674237e into NVIDIA-NeMo:main Aug 28, 2026
177 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants