feat: forward rollout session IDs to Dynamo - #3856
Open
jthomson04 wants to merge 2 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
jthomson04
force-pushed
the
jthomson04/dynamo-session-id-forwarding
branch
from
August 26, 2026 23:52
6ef3f99 to
2af6e1b
Compare
Contributor
Author
|
/ok to test 2af6e1b |
jthomson04
marked this pull request as ready for review
August 27, 2026 23:23
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Forward stable rollout session IDs to Dynamo for NeMo-Gym and direct NeMo-RL rollouts.
X-Dynamo-Session-ID; other backends and Dynamo routing policy are unchanged.NVIDIA-NeMo/Gym@cc8ec02281a590ff9e5111acae8d70fe1dd354abfor optional session-header support.This PR is transport-only. Session affinity remains opt-in through the existing
frontend_args.extra_cli_argsescape hatch. It does not add an affinity default, tracing controls, or a new routing policy.Issues
None.
Usage
No user configuration is required for header forwarding. Dynamo-backed Gym and direct rollouts add the session header automatically. Users who want session affinity can configure the existing Dynamo frontend CLI escape hatch.
Before your PR is "Ready for review"
Pre checks:
Additional Information
Validation:
uv sync --lockedpassed.