Add golden patch adaptations. - #2853
Draft
ffrujeri wants to merge 7 commits into
Draft
Conversation
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
ffrujeri
force-pushed
the
ffrujeri/swebench-pro
branch
4 times, most recently
from
August 31, 2026 04:33
fd20b40 to
f7707d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves OpenSandbox runtime parity and failure diagnostics for SWE-bench Pro golden-patch verification
without changing the upstream patch-application contract or exact test-name grading.
Runtime parity adaptations
The verifier adds opt-in compatibility handling for four OpenSandbox divergences reproduced against the official
Docker evaluator:
OTEL_*configuration for the affected Flipt instance;localhostmay resolveto
::1;PONGfor the affected NodeBB instance instead of treating any successfulredis-cliinvocation as readiness;
Each adaptation is restricted to the exact pinned dataset instance where the divergence was observed. Other Flipt,
NodeBB, and qutebrowser tasks retain their original evaluator scripts and environment.
The existing Go module prefetch remains a separate adaptation. It warms the module cache before running Go tests but
does not rewrite the upstream test command.
Verification diagnostics
The generated entry script now records exit codes independently for:
These statuses are persisted in the evaluation logs and returned by the resources server. Setup, patch, checkout, or
parser failures can therefore be distinguished from ordinary test failures. A failed infrastructure/setup phase
cannot be reported as a completed resolved evaluation, while
grade_output()continues to require the exactfail_to_pass | pass_to_passtest names withPASSEDstatus.OpenSandbox configuration and evaluation helper
linux/amd64, matching the benchmark images.instance_id_prefixesfiltering toapply_golden_patch.pyfor focused retries and diagnostics.Validation
The full stress-run result should not be treated as a strict A/B comparison with the earlier 719/731 run because the
runs used different concurrency and can include unrelated benchmark/runtime flakes. The focused 4/4 run validates
the intended adaptations directly.
No expected test names are normalized, no required tests are skipped, and the three known malformed benchmark
contracts remain unresolved rather than being waived.
Checklist
when applicable).
pre-commit run --all-files) (so CI lint/format/copyright pass).git commit -s) (so the DCO check passes).