Skip to content

fix: preserve batch wrapper exit status - #2838

Open
AdamRajfer wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
AdamRajfer:arajfer/fix-batch-wrapper-shell
Open

fix: preserve batch wrapper exit status#2838
AdamRajfer wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
AdamRajfer:arajfer/fix-batch-wrapper-shell

Conversation

@AdamRajfer

Copy link
Copy Markdown
Contributor

Summary

  • run the generated batch command with a non-login shell
  • preserve its exit status through server teardown
  • cover the submitted wrapper and clean lifecycle path

Tests

  • pytest -q tests/unit_tests/test_opensandbox_cleanup.py
  • pytest -q tests/unit_tests/ -m "not sandbox"
  • pre-commit run --all-files

Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant