Conversation
RX14
reviewed
Feb 22, 2017
| * are now valid Java 8 functional interfaces, making this class unnecessary boilerplate. | ||
| * @author anti344 | ||
| */ | ||
| @Deprecated |
Contributor
There was a problem hiding this comment.
Is there a reason we shouldn't delete this? We don't need backwards compat because we have no releases.
Member
Author
There was a problem hiding this comment.
There isn't any specific reason as to keeping it, I don't even use it in #4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades NOVA-Scala to use Scala 2.12.1
New features:
Note that in Scala:
is still a type of
Function1unless you doin which case it becomes a Java 8
Function.This isn't a problem in Java 8, as Java 8 has to have the type declared.
More about Scala 2.12:
http://www.scala-lang.org/news/2.12.0