Let ROSCO toolbox determine TSR - #476
Merged
Merged
Conversation
* Fully disable 2nd tower mode shapes if DOF is disabled * Fully disable 2nd tower mode shapes if DOF is disabled (NLRWindSystems#466) * Add moorpy version 1.2.1 to environment.yml * move some pypi packages to the conda forge * fix readme (NLRWindSystems#467) * Add Mean_PtfmPitch as an optimization constraint * trying updated wisdem to reduce package dependencies * unlock openmdao * Add some helper functions for platform design * Cd into notebooks for testing * Tidy platform optimization in RAFT * Remove plot_tradeoff * convert radians to degrees for heel constraints * seeing if openmpi speeds up installation * maybe without pyoptsparse for speedup? * one more combo * native mpi * found solution, restoring full test matrix * caught more rad to deg conversions --------- Co-authored-by: Garrett Barter <garrett.barter@nrel.gov> Co-authored-by: Pietro Bortolotti <ptrbortolotti@gmail.com> Co-authored-by: Garrett Barter <gbarter@alum.mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow the ROSCO toolbox to determine the optimal TSR from the Cp surface when tuning ROSCO, rather than only supporting a pre-set TSR from the tuning yaml or the value determined by WISDEM.
resolve_tsr_operational()inweis/control/tune_rosco.py, which resolvesTSR_operational(and the dependent rated wind speed,v_rated) used to tune ROSCO:TSR_operationalis set to0in the ROSCO tuning inputs (rosco_tuning_inputs), it is auto-computed from the Cp surface (Cp.TSR_opt), matching standalone ROSCO's convention inrosco.toolbox.turbine.Turbine.TSR_operationalis set to a positive value, it overrides the WISDEM-provided default (control.rated_TSR/ optimal TSR).TuneROSCO.compute()to callresolve_tsr_operational()once the Cp surface is available, instead of computingv_ratedandTSR_operationaldirectly from the WISDEMtsr_operationalinput.Type of change
Testing
Added
weis/control/test/test_tune_rosco.py, a regression/unit test suite forresolve_tsr_operational()covering:TSR_operational = 0auto-computes the optimal TSR from a synthetic Cp surface (Cp.TSR_opt).TSR_operationaloverrides the WISDEM-provided default.TSR_operationalfrom the ROSCO tuning inputs leaves the WISDEM-provided default unchanged.Checklist