Multiple Switches and Time Series DF Improvements - #201
Merged
Conversation
AadilLatif
reviewed
Jul 30, 2026
AadilLatif
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, just two things:
- In
get_directed_graph— ifswitch_edgesreturns edges that aren't in the DFS tree (the warning branch), the cycle never gets broken and thewhile cycles:loop spins forever. You could pop the cycle off the list in that branch to be safe:
else:
logger.warning(...)
cycles.pop(0)
continue_get_timestampsreturn annotation still says-> listbut the SingleTimeSeries branch now returns apd.DatetimeIndex. Not blocking but worth fixing while you're in there.
Everything else is clean. The numpy-based df assembly is a nice perf win.
AadilLatif
requested changes
Jul 30, 2026
|
AadilLatif
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Change Summary
Related issue number
Checklist