feat: start YouTube transcriptions from Chrome - #35
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2bea56293
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for request in | ||
| drain_single_instance_deep_links(SINGLE_INSTANCE_MUTEX_NAME, started_at_ms) | ||
| { | ||
| if let Err(error) = | ||
| queue_youtube_deep_link_navigation(app.handle(), &request, false) |
There was a problem hiding this comment.
Preserve every queued browser handoff
When two extension launches reach a starting primary instance before the WebView navigation listener is ready, this loop drains both requests and calls queue_youtube_deep_link_navigation for each, but PendingNavigationState::queue stores only one pending value. The emitted events have no listener yet, so each iteration overwrites the previous request and only the final video is transcribed; retain a queue or wait for acknowledgement before advancing to the next request.
AGENTS.md reference: AGENTS.md:L346-L350
Useful? React with 👍 / 👎.
Summary
scriber://youtube/transcribedesktop handoffValidation
node --test browser-extension\chrome\tests\shared.test.cjs(3 passed)cd Frontend && npm run test:lib(98 passed)cd Frontend && npm run checkcd Frontend && npm run lintcd Frontend && npm run build:webviewscripts\project-python.cmd -m pytest tests\api\test_youtube_routes.py -q(15 passed)cargo fmt -- --checkcargo metadata --locked --no-deps --format-version 1Native test note
The focused Rust unit tests could not reach the crate on this workstation because its Visual Studio installation lacks the Windows SDK headers/libraries (
windows.h,kernel32.lib). The PR's Windows CI runner should provide the authoritative native build/test result.