Build(deps): Bump github.com/stretchr/testify from 1.11.1 to 1.12.1 - #167
Closed
MusicalNinjaDad wants to merge 1 commit into
Closed
Build(deps): Bump github.com/stretchr/testify from 1.11.1 to 1.12.1#167MusicalNinjaDad wants to merge 1 commit into
MusicalNinjaDad wants to merge 1 commit into
Conversation
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.11.1 to 1.12.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.11.1...v1.12.1) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-version: 1.12.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The replacement of
gopkg.in/yaml.v3withgo.yaml.in/yaml/v3is non-standard; double-check that this module path is intentional and correctly resolvable in your environment. - Since the
pmezard/go-difflibindirect dependency was removed, confirm that any assertion output or diff-related functionality fromtestifystill behaves as expected with the new version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The replacement of `gopkg.in/yaml.v3` with `go.yaml.in/yaml/v3` is non-standard; double-check that this module path is intentional and correctly resolvable in your environment.
- Since the `pmezard/go-difflib` indirect dependency was removed, confirm that any assertion output or diff-related functionality from `testify` still behaves as expected with the new version.
## Individual Comments
### Comment 1
<location path="go.mod" line_range="16" />
<code_context>
- github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/spf13/pflag v1.0.9 // indirect
- gopkg.in/yaml.v3 v3.0.1 // indirect
+ go.yaml.in/yaml/v3 v3.0.5 // indirect
)
</code_context>
<issue_to_address>
**issue (bug_risk):** The module path `go.yaml.in/yaml/v3` looks incorrect and will likely break dependency resolution.
The prior dependency correctly used `gopkg.in/yaml.v3`. The new path `go.yaml.in/yaml/v3` is not a valid Go module and will cause `go mod tidy` / `go get` to fail. If you’re upgrading to v3.0.5, this line should be `gopkg.in/yaml.v3 v3.0.5` instead.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/spf13/pflag v1.0.9 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.5 // indirect |
There was a problem hiding this comment.
issue (bug_risk): The module path go.yaml.in/yaml/v3 looks incorrect and will likely break dependency resolution.
The prior dependency correctly used gopkg.in/yaml.v3. The new path go.yaml.in/yaml/v3 is not a valid Go module and will cause go mod tidy / go get to fail. If you’re upgrading to v3.0.5, this line should be gopkg.in/yaml.v3 v3.0.5 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.11.1 to 1.12.1.
Updates to go.yaml.in/yaml/v3 and removes pmezard/go-difflib dependency.
Closes #166