Handle already-installed Flatpak debug builds#1
Handle already-installed Flatpak debug builds#1pip-owl wants to merge 2 commits intoMultiboxLabs:mainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2da41f36f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "flatpak", | ||
| ["install", "--user", "-y", bundle], | ||
| { stdio: "inherit" } | ||
| const result = await spawn("flatpak", ["install", "--user", "-y", bundle]); |
There was a problem hiding this comment.
This call awaits spawn with default piped stdio, and spawn only resolves after the child exits, so install output is buffered in memory and printed afterward rather than streamed live. On larger Flatpak installs this removes real-time progress, makes the CLI appear stalled, and can accumulate unnecessarily large stdout/stderr buffers compared with the previous inherited-stdio behavior.
Useful? React with 👍 / 👎.
| installOutput.includes( | ||
| `This version of ${FLOW_FLATPAK_APP_ID} is already installed` |
There was a problem hiding this comment.
The no-op path depends on an exact English sentence, which is brittle across Flatpak locales and message wording changes; when that text differs, rerunning an already-installed build falls through to the throw path and still fails. Since this logic is meant to make reinstall idempotent, it should rely on machine-readable state/flags instead of a hard-coded human message.
Useful? React with 👍 / 👎.
2 participants
Summary
flatpak installoutput directly so Linux installs keep Flatpak's native messaging while still letting the CLI inspect failuresThis version of com.flow_browser.flow is already installedresponse as a no-op so rerunning the same debug build does not fail--openand--open-folderbehavior after a no-op install, and report when the exact debug build is already installedTesting