feat: improve popup windows

src/main/app/urls.ts

@@ -56,7 +56,7 @@ async function openUrlInWindow(useNewWindow: boolean, url: string) {
 
   // Create a new tab with the URL
   const tab = await tabsController.createTab(window.id, undefined, undefined, undefined, { url });
-  tabsController.setActiveTab(tab);
+  tabsController.activateTab(tab);
 }
 
 /**

src/main/controllers/app-menu-controller/menu/items/spaces.ts

@@ -147,6 +147,15 @@ async function createSpaceMenuItem(
  * Creates the Spaces menu for the application
  */
 export async function createSpacesMenu(): Promise<MenuItemConstructorOptions> {
+  const manageSpacesItem = {
+    label: "Manage Spaces",
+    click: () => settings.show()
+  };
+  const noSpacesMenu = {
+    label: "Spaces",
+    submenu: [manageSpacesItem]
+  };
+
   try {
     const [spaces, areProfilesInternal] = await Promise.all([
       spacesController.getAll(),
@@ -156,30 +165,18 @@ export async function createSpacesMenu(): Promise<MenuItemConstructorOptions> {
 
     const focusedWindow = windowsController.getFocused();
     if (!focusedWindow || !browserWindowsManager.isInstanceOf(focusedWindow)) {
-      return {
-        label: "Spaces",
-        submenu: [
-          {
-            label: "Manage Spaces",
-            click: () => settings.show()
-          }
-        ]
-      };
+      return noSpacesMenu;
+    }
+
+    if (focusedWindow.browserWindowType === "popup") {
+      return noSpacesMenu;
     }
 
     const currentSpaceId = focusedWindow.currentSpaceId;
     if (currentSpaceId) {
       const currentSpace = spaces.find((space) => space.id === currentSpaceId);
       if (currentSpace && areProfilesInternal[currentSpace.profileId]) {
-        return {
-          label: "Spaces",
-          submenu: [
-            {
-              label: "Manage Spaces",
-              click: () => settings.show()
-            }
-          ]
-        };
+        return noSpacesMenu;
       }
     }
 
@@ -196,26 +193,11 @@ export async function createSpacesMenu(): Promise<MenuItemConstructorOptions> {
 
     return {
       label: "Spaces",
-      submenu: [
-        ...spaceMenuItems,
-        { type: "separator" },
-        {
-          label: "Manage Spaces",
-          click: () => settings.show()
-        }
-      ]
+      submenu: [...spaceMenuItems, { type: "separator" }, manageSpacesItem]
     };
   } catch (error) {
     console.error("Failed to create spaces menu:", error);
     // Provide a fallback menu if the spaces menu creation fails
-    return {
-      label: "Spaces",
-      submenu: [
-        {
-          label: "Manage Spaces",
-          click: () => settings.show()
-        }
-      ]
-    };
+    return noSpacesMenu;
   }
 }

src/main/controllers/loaded-profiles-controller/index.ts

@@ -144,7 +144,7 @@ class LoadedProfilesController extends TypedEventEmitter<LoadedProfilesControlle
           url: tabDetails.url
         });
         if (tabDetails.active) {
-          tabsController.setActiveTab(tab);
+          tabsController.activateTab(tab);
         }
 
         const electronWindow = tab.getWindow().browserWindow;
@@ -160,7 +160,7 @@ class LoadedProfilesController extends TypedEventEmitter<LoadedProfilesControlle
         setWindowSpace(window, tab.spaceId);
 
         // Set the active tab
-        tabsController.setActiveTab(tab);
+        tabsController.activateTab(tab);
       },
       removeTab: (tabWebContents) => {
         const tab = tabsController.getTabByWebContents(tabWebContents);
@@ -188,7 +188,7 @@ class LoadedProfilesController extends TypedEventEmitter<LoadedProfilesControlle
 
             tabsController.createTab(window.id, profileId, undefined, undefined, { url }).then((tab) => {
               if (currentTabIndex === 0) {
-                tabsController.setActiveTab(tab);
+                tabsController.activateTab(tab);
               }
             });
 

src/main/controllers/tabs-controller/context-menu.ts

@@ -58,7 +58,7 @@ export function createTabContextMenu(
           undefined,
           { url }
         );
-        tabsController.setActiveTab(sourceTab);
+        tabsController.activateTab(sourceTab);
       };
 
       // Create all menu sections