Repository navigation
build: keep dependency locking, drop nebula.release (into #68) - #72
Merged
soloturn merged 1 commit intoSep 28, 2026
Conversation
Terasology, gestalt and this repo all version from a hand-edited SNAPSHOT string that Jenkins publishes from long-lived branches. nebula.release would make CrashReporter the one Maven-published repo versioned from git tags, and a plain `publish` on master would ship `5.2.0-dev.N+sha` in place of today's `5.2.0-SNAPSHOT`. Locking stands on its own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
agent-refr
changed the base branch from
master
to
feat/nebula-versioning-and-lockfile
September 28, 2026 15:22
2 tasks done
soloturn
merged commit Sep 28, 2026
84ef6e5
into
MovingBlocks:feat/nebula-versioning-and-lockfile
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets #68's branch, not master: it keeps the dependency locking half of #68 and removes the nebula.release half, so #68 can land as a locking-only change.
engine/module.txt), gestalt (gradle.properties) and CrashReporter (gradle.properties) all carry a hand-edited-SNAPSHOTversion that Jenkins publishes from the long-lived branches. That is the community's one release convention today, and adopting tag-driven versioning in a small utility first would leave it the odd repo out.publishon master resolves to5.2.0-dev.9+c305ae6(checked with:cr-core:propertieson this branch), so the5.2.0-SNAPSHOTstream Artifactory holds today would stop updating and a new dev version would land per merge.Dependency locking is unaffected and stays exactly as #68 wrote it, including
-PnoLock.Test plan
./gradlew dependencies --write-locksregeneratedbuildscript-gradle.lockfileto the empty classpath; subproject lockfiles unchanged../gradlew buildcompiles and verifies locks. The threeErrorMessagePanel*test failures seen locally are the Windows temp-dir issue fixed in fix(reporter): PasteBin upload - timeout, missing Jackson dep, silent failures #70, which this branch predates.Related
--write-locksto pick up fix(reporter): PasteBin upload - timeout, missing Jackson dep, silent failures #70's Jackson dependencies.