Conversation
- Implemented a new Hall of Supporters / Hall of Roles feature in zander-hub. - Features auto-population based on LuckPerms groups and priority. - Added YAML-based persistence for sections, slots, assignments, and customizations. - Implemented a player customization GUI for armor, items, and poses. - Added comprehensive admin commands for managing the hall. - Optimized performance with asynchronous LuckPerms lookups and assignment refreshes. - Ensured forced identity (player head and username) and plugin-controlled signs. - Added granular permissions for all features. - Included full admin documentation in docs/hall-of-supporters.md. Co-authored-by: benrobson <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Added /hall section list and /hall slot list commands for better visibility. - Added /hall info subcommands for detailed section and slot information. - Improved slot creation to support custom readable IDs. - Added a step-by-step Quick Start Guide to docs/hall-of-supporters.md. - Fixed compilation errors in MyStatueCommand. - Enhanced user feedback and permission messaging. - Ensured all operations are optimized and non-blocking. Co-authored-by: benrobson <[email protected]>
- Fully implemented Hall of Supporters with LuckPerms auto-population. - Added YAML-based storage for sections, slots, assignments, and customizations. - Implemented customization GUI with armor, items, poses, and particle effects. - Added comprehensive admin commands with granular permissions. - Optimized performance with asynchronous lookups and chunk-aware rendering. - Created detailed admin setup guide and user customization guide. - Addressed code review feedback (multi-word labels, disabled gravity for statues). Co-authored-by: benrobson <[email protected]>
- Implemented Shift+Right-Click (with empty hand) on statues to open customization GUI. - Fixed statue rotation issue (statues now face the direction they were created). - Added requested lore/tooltips to the customization GUI items. - Extensively improved documentation with clearer examples and setup instructions. - Improved rendering robustness (teleporting entities to exact locations, removing duplicates). - Fixed missing import in HallProtection.java. Co-authored-by: benrobson <[email protected]>
- Integrated Hall of Supporters / Hall of Roles into zander-hub. - Implemented YAML-based persistence for sections, slots, assignments, and customizations. - Added LuckPerms integration for automated player assignment based on groups and weights. - Created an interactive GUI for players to customize their assigned statues (armor, items, poses). - Added administrative commands for managing the hall (/hall). - Implemented protection logic to prevent unauthorized statue manipulation. - Added comprehensive documentation in docs/ and updated README.md. Co-authored-by: benrobson <[email protected]>
- Updated LuckPermsService to fetch global group members using searchAll API, allowing players who haven't joined the Hub to be auto-populated. - Improved RenderService sign orientation logic to align sign rotation with statue yaw. - Updated documentation with information on dynamic sorting and slot locking. - Verified build compatibility with LuckPerms API 5.4. Co-authored-by: benrobson <[email protected]>
1 participant
Implemented the Hall of Supporters feature in the zander-hub plugin. This feature automatically populates armor stand statues and signs with eligible players based on their LuckPerms groups. It includes a customization GUI for players, comprehensive admin commands, and is optimized for performance with asynchronous operations.
PR created automatically by Jules for task 10503413425520367465 started by @benrobson