Merge HolyScript and Implement Public API#3
Conversation
- Integrated Bible reading feature from HolyScript. - Added Bible model, API client, and caching. - Implemented `/bible` and `/bibledefault` commands. - Exposed `DevoteMeAPI` for other plugins to access VOTD, Devotions, and Bible content. - Updated player data storage to persist Bible version preferences. - Added Bible-related configuration to config.yml. Co-authored-by: benrobson <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Integrated Bible reading feature from HolyScript. - Added Bible model, API client, and caching. - Implemented `/bible` and `/bibledefault` commands. - Exposed `DevoteMeAPI` for other plugins to access spiritual content. - Updated README.md with features, installation, commands, and API docs. - Ensured all tests pass and documented developer API access. Co-authored-by: benrobson <[email protected]>
I have successfully merged the HolyScript Bible feature into the DevoteMe plugin and implemented a public API for other plugins to use.
Key Changes:
/bibleto browse and read the Bible in-game via interactive books.BibleApiClientto fetch content fromscripture.api.bibleandBibleCacheManagerto store chapters locally, reducing API calls./bibledefault, which is saved per-player.DevoteMeAPIandDevoteMeAPIProvider, allowing other plugins to soft-depend on DevoteMe and request VOTD, devotions, or Bible chapters programmatically.PlayerDataStoreto handle both VOTD timestamps and Bible preferences more robustly.mvn clean packageand added unit tests for the new Bible models.PR created automatically by Jules for task 3703664784155811627 started by @benrobson