Skip to content

Merge HolyScript and Implement Public API#3

Open
benrobson wants to merge 2 commits intofeature/devoteme-minecraft-plugin-188289012366095486from
feature/bible-api-integration-3703664784155811627
Open

Merge HolyScript and Implement Public API#3
benrobson wants to merge 2 commits intofeature/devoteme-minecraft-plugin-188289012366095486from
feature/bible-api-integration-3703664784155811627

Conversation

@benrobson
Copy link
Copy Markdown
Member

I have successfully merged the HolyScript Bible feature into the DevoteMe plugin and implemented a public API for other plugins to use.

Key Changes:

  • Bible Feature Integration: Players can now use /bible to browse and read the Bible in-game via interactive books.
  • API Client & Caching: Added BibleApiClient to fetch content from scripture.api.bible and BibleCacheManager to store chapters locally, reducing API calls.
  • Player Preferences: Players can set their preferred Bible translation (CSB, NIV, KJV, ESV) using /bibledefault, which is saved per-player.
  • Public API: Introduced DevoteMeAPI and DevoteMeAPIProvider, allowing other plugins to soft-depend on DevoteMe and request VOTD, devotions, or Bible chapters programmatically.
  • Improved Storage: Updated PlayerDataStore to handle both VOTD timestamps and Bible preferences more robustly.
  • Verification: Verified the build with mvn clean package and added unit tests for the new Bible models.

PR created automatically by Jules for task 3703664784155811627 started by @benrobson

- Integrated Bible reading feature from HolyScript.
- Added Bible model, API client, and caching.
- Implemented `/bible` and `/bibledefault` commands.
- Exposed `DevoteMeAPI` for other plugins to access VOTD, Devotions, and Bible content.
- Updated player data storage to persist Bible version preferences.
- Added Bible-related configuration to config.yml.

Co-authored-by: benrobson <[email protected]>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: faa2596c-6d8d-46f2-93f5-3c021b406b8f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/bible-api-integration-3703664784155811627

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Integrated Bible reading feature from HolyScript.
- Added Bible model, API client, and caching.
- Implemented `/bible` and `/bibledefault` commands.
- Exposed `DevoteMeAPI` for other plugins to access spiritual content.
- Updated README.md with features, installation, commands, and API docs.
- Ensured all tests pass and documented developer API access.

Co-authored-by: benrobson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant