perf: a bunch of optimization#2417
Open
SimplisticMind wants to merge 2 commits into
Open
Conversation
Member
|
Thanks for the PR, it would be easier and more likely to be accepted if you split it in smaller chunk because as it stands, it's complicated to review (and cherry-picking would take a lot of time). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large one so if you want to just cherrypick - feel free to do so; with that out of the way, a few less obvious ones:
envfs.h - upwards of ~20%+ faster refreshing
moapplication.cpp - Qt elements render up to twice as fast
settings.cpp - most impactful settings got hoisted out, other ones aren't hot enough to really necessitate such hoisting too
fileregister.cpp - sortOrigins() - 4x faster compared to locking each file seperately