Many improvements to AutoSign#4594
Many improvements to AutoSign#4594RealMuffinTime wants to merge 7 commits intoMeteorDevelopment:masterfrom
Conversation
|
what was wrong with the time placeholder? it looks correct from looking at the code |
|
It was not wrong, but it did always overwrite the time placeholder from the Starscript StandardLib.timeFormat object. |
ahh i see |
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
Outdated
Show resolved
Hide resolved
(in hope for starscript date and timezone formating)
|
While testing I found some bigger issues, need to look into how to solve these. |
what are the issues? |
|
First something unrelated: sign.getEditor() is always null for me? So the module works fine on a server which accepts sign editing (vanilla). |
|
I tried to use sign.getEditor() to verify if the BlockInteraction was successfull and if the sign could be edited. |
add warning if server does not support sign edit
fix expected packet reset
|
Is checked and tested. Added a warning, if server doesn't support back sign editing. |
|
Hi, I would really like, to see this merged. :) Or is there something else holding up this PR? |
Type of change
Description
When not applying anything, open edit screen normally
How Has This Been Tested?
Checklist: