Side by side animations#155
Open
cosunae wants to merge 34 commits into
Open
Conversation
Co-authored-by: Francesco Zanetta <62377868+frazane@users.noreply.github.com> Co-authored-by: Michele Cattaneo <44707621+MicheleCattaneo@users.noreply.github.com> Co-authored-by: Hugues de Laroussilhe <hugues.delaroussilhe@meteoswiss.ch>
…d (as in baseline)
Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
frazane
reviewed
May 18, 2026
Contributor
frazane
left a comment
frazane
left a comment
There was a problem hiding this comment.
Minor details. Looks very nice! Would you mind documenting somewhere your approach for wildcard constraints?
| return state | ||
|
|
||
|
|
||
| def load_state_from_zarr( |
Contributor
There was a problem hiding this comment.
Would it make sense to wait for #153 and read from GRIB files directly?
Contributor
Author
There was a problem hiding this comment.
Yes, I thought so, but unfortunately the truth seems to stay in zarr, so I am assuming we need it still to be able to plot the truth?
| """ | ||
|
|
||
|
|
||
| rule make_zarr_animation: |
Contributor
There was a problem hiding this comment.
Rule name should start with module name, see https://github.com/MeteoSwiss/evalml#workflow-development-guidelines
| return [f"{i:03}" for i in range(start, total + 1, step)] | ||
|
|
||
|
|
||
| rule plot_zarr_frame: |
| """ | ||
|
|
||
|
|
||
| rule make_comparison_animation: |
Contributor
There was a problem hiding this comment.
Rule name does not follow guidelines, logging is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to generate side by side animations.
The animations config (based on #144 ) allows to set the animation speed and the two panesl of the comparison (refering by label)
This PR implements the following functionality:
This PR implements the following config syntax:
TO BE MERGED AFTER #144