chore: Add Code Connect for SelectButton - #1487
Conversation
📖 Storybook LinksCompare the preview for this pull request with the latest Storybooks from the 🔀 Pull Request Preview
🌳 Main Branch (Latest)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7517e34. Configure here.
| isDisabled: figma.enum('isDisabled', { | ||
| true: true, | ||
| false: undefined, | ||
| }), |
There was a problem hiding this comment.
Disabled mapped with enum helper
Medium Severity
isDisabled is mapped with figma.enum even though it is a boolean property. Other button Code Connect files bind this with figma.boolean, including when false is omitted from the snippet. Using figma.enum can leave the Figma snippet out of sync when the disabled state is toggled.
Reviewed by Cursor Bugbot for commit 7517e34. Configure here.
There was a problem hiding this comment.
Unable to do boolean to buttons due to structure of buttonbase and apperance within figma


Description
Adds Figma Code Connect mappings for React Native.
SelectButton.figma.tsx
New
SelectButton.figma.tsxfor React NativeMatched props
variant→variantsize→sizeisDisabled→isDisabled(truewhen disabled; omitted whenfalse)label(nestedButtonBase) →placeholder(viafigma.nestedProps())Intentionally omits Figma-only properties:
startIcon (Figma Only),endIcon (Figma Only),hasAvatar (Figma Only),hasBadge (Figma Only)SelectButtonexists only in@metamask/design-system-react-native, so no React web mapping was added.The snippet matches Storybook Default usage:
placeholder,variant,size,endArrowDirection={SelectButtonEndArrow.Down},isDisabled, andonPress={() => undefined}.Related issues
Manual testing steps
size,variant,isDisabled) and verify the snippet updatesScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Made with Cursor