fix: restore endowment:assets permission to Bitcoin, Solana, and Tron snaps - #274
Merged
Conversation
ulissesferreira
changed the title
endowment:assets permission to bitcoin, solana, and tron snapsendowment:assets permission to bitcoin, solana, and tron snaps
ulissesferreira
changed the title
endowment:assets permission to bitcoin, solana, and tron snapsendowment:assets permission to Bitcoin, Solana, and Tron snaps
ulissesferreira
force-pushed
the
restore-endowment-assets
branch
from
September 4, 2026 14:24
e746914 to
fe6c365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
endowment:assetspermission was removed from the bitcoin, solana, and tron snaps in #260, #261, and #263, together with their asset handler entry points. This PR brings the permission back so the snaps request the assets scopes again (the stellar snap never lost it).Summary
endowment:assetsfield in each snap'ssnap.manifest.jsonwith the exact scopes it had before the removal commits:bitcoin-wallet-snap: the fivebip122mainnet/testnet/regtest scopessolana-wallet-snap:solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdpandsolana:EtWTRABZaYq6iMfeYKouRu166VU2xqa1tron-wallet-snap:tron:728126428endowment:assetsis a handler endowment, so the manifest validator strips it unless the snap exports asset handlers. Adds no-oponAssetsLookup,onAssetsConversion,onAssetHistoricalPrice, andonAssetsMarketDataentry points to each snap to keep the permission.Validation
yarn workspace <pkg> run buildpasses for all three snaps and the permission survives the build's manifest checkyarn workspace <pkg> run testpasses for all three snapstsc --noEmitand ESLint clean,yarn changelog:validatepasses