use windows-2025 github runners#6189
Open
Fedr wants to merge 5 commits into
Open
Conversation
Fedr
added
full-ci
Resolve the VS install path at runtime instead of hardcoding the 2022 Enterprise path, which does not exist on windows-2025 runners. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pin the VS2022 vcpkg triplet and the matching v143 toolset so the windows-2025 runner doesn't implicitly pick up a newer toolset. v143 keeps MRCudaVersion at 12.0 (source/platform.props) to match the installed CUDA 12.0 BuildCustomizations. The triplet is wired through vcpkg setup, the MSBuild build, and the MRBind generate step. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The same vswhere-based VS lookup was duplicated in build-test-windows and pip-build. Move it to .github/actions/locate-visual-studio, which still exports VC_PATH for later steps and also exposes a `path` output. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replace the single windows-latest runner with a matrix of windows-2022 and windows-2025 so the wheel is exercised on both the image that built it and the previous one. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.