Add the INSPIRE dataset - #308
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
8048c83 to
48c84ef
Compare
Prerequisite for the per-dataset registration PRs (#305 AUMCdb, #306 EHRShot, #307 HIRID, #308 INSPIRE, #309 NWICU, #310 SICdb, #311 eICU). Most of those datasets' upstream extractors don't ship a publicly installable demo, and the existing registry validation requires every dataset to declare a build_demo command. Switches the convention to: a dataset has a demo iff its commands declare build_demo. Absence is the signal — no separate metadata field. - `test_all_datasets_have_commands` now requires `build_full` (which every dataset still needs) and allows missing `build_demo`. - `tests/conftest.py` drops datasets without `build_demo` from the integration test matrix, so a per-dataset CI lane for one collects zero parametrized tests and passes cleanly rather than trying to build data the dataset can't produce. - `src/MEDS_DEV/datasets/__main__.py` raises a clear error when called with `demo=True` against a dataset that doesn't declare a build_demo command (instead of the previous KeyError). No dataset.yaml files change here — those changes ship with the sister per-dataset PRs that depend on this one. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
17019a0 to
a2d4038
Compare
48c84ef to
d79e827
Compare
d79e827 to
5cd613c
Compare
|
I checked the The package declares This seems to have been fixed in |
|
I think I understand why CI did not catch this. Although the As a result, |
Summary
Registers INSPIRE (perioperative medicine) in
src/MEDS_DEV/datasets/INSPIRE/. Extraction is viaMEDS_extract-INSPIREfrom the upstreaminspire-medspackage.Files added:
dataset.yaml— metadata +build_fullshelling out toMEDS_extract-INSPIRE. Nobuild_demo(upstream doesn't ship a demo recipe; Makebuild_demooptional, skip demo-less datasets in tests #312 makes the key optional and ensures integration tests skip it).predicates.yaml— admission/discharge plus a few lab/vital predicates. Regex syntax bugs (^X*form) and commented-out predicate stubs from the contributor's branch were cleaned up.requirements.txt—INSPIRE-MEDS==0.0.11.refs.bib.README.md.INSPIRE is not added to any task's
supported_datasets.Depends on #312
#312 makes
build_demooptional in the registry and skips datasets that don't declare it from the integration test matrix. Targeted atfeat/dataset-demo-availabilityfor now; once #312 merges, this PR retargets todev.Test plan
build_demooptional, skip demo-less datasets in tests #312.Supersedes / refs
🤖 Generated with Claude Code