Feature/linux wayland bundled render

[MaxMB15]

This pull request introduces several important improvements and fixes across the Linux desktop app and the mpv integration, with a particular focus on more robust audio diagnostics, improved environment handling, and code cleanup. The most significant changes are grouped below.

Linux Environment Handling and Diagnostics

• Refactored Linux-specific environment setup in lib.rs to improve detection and handling of AppImage and Wayland/X11 sessions. Now, DMABUF is only disabled on X11, and GDK_BACKEND is set to "wayland" when appropriate. The custom crash handler and display environment logging were removed for simplicity and maintainability. [1] [2]

Audio Diagnostics and mpv Integration

• Added comprehensive audio diagnostics to MpvEngine in engine.rs, including methods to log mpv audio state, force audio track selection if needed, and ensure audio properties are set after initialization. This helps diagnose and automatically recover from "no sound" issues. [1] [2] [3] [4] [5] [6]
• Updated MpvState in mpv.rs to call the new audio configuration and diagnostics methods after creating or launching mpv, including fallback scenarios. [1] [2]
• Improved thread safety and error handling in the stop method by handling poisoned mutexes gracefully.

Build System Improvements

• Updated the build.rs script to bake RPATH into the binary on Linux, ensuring the correct libmpv.so is used at runtime and avoiding mismatches with system libraries.

Frontend Usability and Initialization

• Improved keyboard usability in the player by auto-focusing the player container on load and after channel changes, ensuring keyboard controls work immediately.
• Fixed the initialization logic in useChannels so that the splash screen is only dismissed after both providers and channels are loaded, preventing premature UI display. [1] [2]

Other changes include minor formatting cleanups and improved code readability in several frontend components.

[Copilot]

Pull request overview

This PR refactors Linux (Wayland) embedded rendering for the Tauri mpv plugin, adds mpv-side audio diagnostics/recovery, and tightens Linux/AppImage environment + bundling behavior to reduce runtime mismatches and “no sound / blank window” reports.

Changes:

• Reworked Linux embedded renderer to be Wayland-only and pass the native wl_display into libmpv, plus restructured EGL/Wayland resource ownership and resize handling.
• Added mpv audio configuration + logging (including “no AO backends compiled in” diagnostics) and hooked it into normal and fallback launch flows.
• Improved AppImage/runtime behavior (env workarounds), bundling scripts, and a Linux RPATH hint; plus small frontend UX/init tweaks (auto-focus player, splash gating).

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
scripts/bundle-libmpv-linux.sh	Expands “do not bundle” system lib filter and adds a bundled-library inventory for CI audit.
scripts/build-libmpv.sh	Makes missing audio dev packages a hard error to prevent producing a silent libmpv build.
crates/tauri-plugin-mpv/src/renderer.rs	Adds an optional set_first_frame_callback to the renderer trait.
crates/tauri-plugin-mpv/src/mpv.rs	Calls new audio configuration in Linux load/fallback; improves poisoned-lock handling in stop.
crates/tauri-plugin-mpv/src/linux.rs	Major Wayland-only renderer rewrite: EGL/Wayland lifecycle, resize strategy, update callbacks, Wayland display param for libmpv.
crates/tauri-plugin-mpv/src/engine.rs	Adds audio diagnostics/configuration and a “log once after playback starts” check; logs create options.
crates/tauri-plugin-mpv/build.rs	Adds Linux RPATH link arg when linking against libs/linux/libmpv.so.
apps/desktop/src/hooks/useUpdateChecker.ts	Formatting-only change to progress updates.
apps/desktop/src/hooks/useMpv.ts	Formatting-only change to first-frame-ready restore conditional.
apps/desktop/src/hooks/useChannels.ts	Ensures splash initialized is set only after both providers and channels load.
apps/desktop/src/components/player/VideoPlayer.tsx	Auto-focuses player container on mount and after channel changes for immediate keyboard control.
apps/desktop/src/components/channels/RecentlyPlayedRow.tsx	Formatting-only JSX restructuring.
apps/desktop/src/components/channels/PinnedGroupsRow.tsx	Formatting-only JSX restructuring.
apps/desktop/src/components/channels/CategoryManager.tsx	Formatting-only JSX restructuring.
apps/desktop/src-tauri/src/lib.rs	Simplifies Linux env handling: AppImage DMABUF + Wayland GDK_BACKEND adjustments; removes crash handler and env logging.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

render_frame returns early when update() reports no new frame. Because set_frame explicitly schedules render_frame to apply resizes (including when paused), this can leave the surface cleared to black after a resize with no subsequent redraw of the last frame. Consider rendering when a resize occurred (even if mpv_render_update::Frame is not set) so paused/idle resizes repaint the last frame instead of staying black.

Suggested change

	if !has_frame {
	if !has_frame && !resized {

[Copilot]

run_on_glib_main blocks on rx.recv() with no timeout. If the GLib main loop is not running yet, is stalled, or is shutting down (e.g. during app teardown while Drop calls detach), this can deadlock the calling thread indefinitely. Consider using recv_timeout with a reasonable bound and returning an error (or falling back) on timeout.

Suggested change

	rx.recv()
	.expect("GLib main thread dispatch channel dropped before sending")
	match rx.recv_timeout(std::time::Duration::from_secs(5)) {
	Ok(value) => value,
	Err(std::sync::mpsc::RecvTimeoutError::Timeout) => {
	panic!("timed out waiting for GLib main thread dispatch to complete")
	}
	Err(std::sync::mpsc::RecvTimeoutError::Disconnected) => {
	panic!("GLib main thread dispatch channel dropped before sending")
	}
	}

[Copilot]

The safety comment claims dlopen is async-signal-safe. It is generally not async-signal-safe per POSIX, so this is misleading and could encourage unsafe usage patterns in future edits. Suggest rewording to only state the properties you rely on here (e.g., thread-safety and process-lifetime validity) without asserting async-signal-safety.

Suggested change

	// SAFETY: `load_required` wraps `dlopen("libEGL.so.1")`; dlopen is
	// async-signal-safe and thread-safe, and the returned instance is
	// valid for the lifetime of the process.
	// SAFETY: `load_required` wraps `dlopen("libEGL.so.1")`. Here we
	// only rely on one-time initialization via `OnceLock` and on the
	// loaded library / returned instance remaining valid for the
	// lifetime of the process.

[Copilot]

set_first_frame_callback silently ignores poisoned mutexes (lock() error path), which would drop the callback and make the frontend never receive mpv://first-frame. Since other methods in this file handle poisoning via into_inner(), consider doing the same here (or at least logging) so the callback is still stored.

Suggested change

	if let Ok(mut slot) = self.first_frame_cb.lock() {
	*slot = Some(cb);
	}
	let mut slot = match self.first_frame_cb.lock() {
	Ok(slot) => slot,
	Err(poisoned) => {
	tracing::warn!(
	"[MPV] first_frame_cb mutex was poisoned; recovering callback slot"
	);
	poisoned.into_inner()
	}
	};
	*slot = Some(cb);

[Copilot]

The dummy const used solely to reference Weak is a maintenance hazard and obscures intent. A clearer approach is to either remove the Weak import entirely, or use the imported Weak directly (e.g., in the Arc::new_cyclic closure parameter type) so it’s naturally referenced without a sentinel item.