feat: progress counter and collapsed per-site lists - #9
Merged
Merged
Conversation
This was referenced Sep 13, 2026
In-progress feature lines used ui_step, so a running feature looked finished; there was no i/n counter; and HTTP/3/Redis printed one ui_step_path line per site (30+ identical lines on big wp-test boxes). apply_optimizations now collects the post-filter feature list first and prints ui_step_pending "Applying <name>... [i/n]" while a feature runs (result lines unchanged -- that wording is PR #5's scope). New site_list_begin/step/flush helpers in lib/core/helpers.sh buffer per-site lines: >5 sites collapses to one "<text> -> N sites" summary, <=5 or --verbose keeps the full list. Wired into the HTTP/3 and Redis apply paths. Closes #8
get_nginx_sites_dir returned 1 when no sites-enabled existed. Under set -e, sites_dir=$(get_nginx_sites_dir) killed optimize --dry-run right after the DRY RUN banner on CI (no nginx), so the Would apply assertion never saw a summary. Lookups now return 0 with empty stdout.
MarcinDudekDev
force-pushed
the
feat/progress-indicators
branch
from
September 13, 2026 19:04
4c69fd7 to
1426c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Optimize now shows where it is, and stops dumping one line per site.
ui_step_pending "Applying <name>... [i/n]"(○, not a completed checkmark) while a feature runs. Result-line wording (applied/failed) unchanged — that is PR fix: clean up dry-run output in interactive mode #5.Would configure HTTP/3 -> 33 sites).--verbosekeeps the full list. 5 or fewer sites stay per-site.Tests: new Section 21 in
tests/run-tests.sh(fail on main). 114/114 on this branch. shellcheck --severity=warning clean.Independent of PR #5 (dry-run wording) and PR #7 (JSON). Branched from main.